feat: adopt x-openregister-lifecycle on 5 softwarecatalogus schemas#209
Open
rubenvdlinde wants to merge 2 commits intodevelopmentfrom
Open
feat: adopt x-openregister-lifecycle on 5 softwarecatalogus schemas#209rubenvdlinde wants to merge 2 commits intodevelopmentfrom
rubenvdlinde wants to merge 2 commits intodevelopmentfrom
Conversation
See ConductionNL/nextcloud-app-template#19 for root-cause fix in the template.
Annotates every schema in the softwarecatalogus register that has a status enum: | Schema | Actions | |--------------|---------| | organisatie | activate, deactivate, reactivate | | gebruik | plan, goLive, phaseOut, retire | | contract | sign, expire, renegotiate | | koppeling | release, sunset, withdraw | | moduleVersie | release, sunset, withdraw | OpenRegister's LifecycleValidationListener now enforces every status move on these schemas. Status changes that skip steps (e.g. organisatie Concept → Deactief without going through Actief) are rejected via HookStoppedException → HTTP 422. Companion: ConductionNL/openregister#1357
Contributor
Quality Report — ConductionNL/softwarecatalog @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 120/120 | |||
| npm | ✅ | ✅ 582/582 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-29 12:01 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotates organisatie, gebruik, contract, koppeling, moduleVersie schemas. Companion: ConductionNL/openregister#1357