chore: remove orphaned settings views (UserSettings, PartnerAdmin)#426
Merged
Conversation
….vue) Both files under src/views/settings/ are imported by nothing — verified across src/, templates/, appinfo/, webpack.config.js, src/customComponents.js and src/manifest.json. UserSettings.vue is a leftover scaffold view; PartnerAdmin.vue is the pre-manifest custom partner-organisations admin, superseded by the manifest's declarative `Partners` page. Procest's admin settings live in src/views/settings/AdminRoot.vue (the `#procest-settings` entry). Purely subtractive — no imports removed, no manifest change, no behavior change. (Procest's remaining `type:"custom"` pages — the vue-flow workflow editor, the three public pages, the aggregate work-queue dashboards, the admin-section pages, the filter-tab/computed-column Voorstellen list — are custom for real reasons; the marginal conversions there are per-page work for the team's PR pipeline.)
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Coverage: 0% (0/81 statements)
Spec coverage: 5% (21 tests / 456 specs)
Quality workflow — 2026-05-12 17:39 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
src/views/settings/UserSettings.vueandsrc/views/settings/PartnerAdmin.vue— both imported by nothing (verified acrosssrc/,templates/,appinfo/,webpack.config.js,customComponents.js,manifest.json).UserSettings.vueis a leftover scaffold;PartnerAdmin.vueis the pre-manifest custom partner-organisations admin, superseded by the manifest's declarativePartnerspage. Admin settings live inAdminRoot.vue.Purely subtractive — no imports removed, no manifest change, no behavior change.
Audit note: procest's other
type:"custom"pages (vue-flow workflow editor, the 3 public pages, aggregate work-queue dashboards, admin-section pages, the filter-tab/computed-columnVoorstellenlist) are custom for real reasons — the genuinely-convertible remainder is per-page work best done in focused PRs through the team pipeline.