docs(parafering): OR ApprovalService migration plan (closes #407)#413
Open
rubenvdlinde wants to merge 1 commit into
Open
docs(parafering): OR ApprovalService migration plan (closes #407)#413rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Implements migrate-parafering-to-or-approval-workflow — scope-adjusted to a documentation/planning PR. Investigation: ParaferingService operates on array-shaped voorstel objects and never sees ObjectEntity. OR ApprovalService needs ObjectEntity; only the controller can resolve it at persistence time. Clean delegation requires a coordinated 4-step rewrite (controller pass-through + service rewrite + notification listener conversion + frontend event-stream consumption) that does not fit a single focused PR. This commit records: - The migration plan as four sequential follow-up PRs. - The ADR-022 rule going forward: every NEW parafering route MUST go through OR ApprovalService. - The legacy in-array path stays read-only-compatible during transition. Closes #407
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 5% (21 tests / 456 specs)
Quality workflow — 2026-05-11 22:03 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adoption-only scope. ParaferingService array-API can't delegate to OR ApprovalService without controller-side ObjectEntity resolution. Records the 4-step migration plan (controller, service, notification listener, frontend); each ships as a follow-up PR. Closes #407.