docs(audit): record parafering audit umbrella rule (closes #406)#412
Open
rubenvdlinde wants to merge 1 commit into
Open
docs(audit): record parafering audit umbrella rule (closes #406)#412rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
… needed) Implements migrate-parafering-to-or-audit — adoption-only scope per investigation. Investigation finding: - No `ParaferingAuditListener.php` exists. - No `ParaferingAuditAppendOnlyValidator.php` exists. - No `paraferingAuditEntry` schema in procest_register.json. - `Application.php` has no audit-listener registrations. - Parafering audit currently lives as an in-object `auditTrail` array on the voorstel inside `ParaferingService`. The spec's framing (separate listener + parallel schema + append-only validator) does not match procest's code. Future parafering audit work MUST route through OR's `AuditTrailMapper::createAuditTrailEntry()` per the umbrella consume-or-audit-trail-fleet-wide (ADR-022). The in-object `auditTrail` array migration is a follow-up — it needs concurrent updates to readers in views and a controller-side ObjectEntity resolution step the current array-only ParaferingService API doesn't provide. Tasks updated to reflect the codebase-vs-spec gap. Closes #406
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 5% (21 tests / 456 specs)
Quality workflow — 2026-05-11 22:00 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements migrate-parafering-to-or-audit — adoption-only scope per investigation.
Investigation finding
The spec assumed procest had a
ParaferingAuditListener+ParaferingAuditAppendOnlyValidator+paraferingAuditEntryschema. None exist. The Listener dir contains onlyDeepLinkRegistrationListener+KpiCacheInvalidationListener, and Application.php has no audit-listener registrations.Parafering audit today lives as an in-object
auditTrailarray on the voorstel insideParaferingService. The spec's framing doesn't match the code.What this PR does
Records the umbrella rule in the spec so any future parafering-audit work routes through OR's
AuditTrailMapper::createAuditTrailEntry()per ADR-022. The in-object array migration is a follow-up — it needs concurrent reader updates in views + a controller-side ObjectEntity resolution step that the current ParaferingService array-only API doesn't provide.Scope adjustment documented inline in tasks.md.
Closes #406.