feat(pdok): route PDOK lookups through openconnector (closes #404)#410
Open
rubenvdlinde wants to merge 1 commit into
Open
feat(pdok): route PDOK lookups through openconnector (closes #404)#410rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Implements openspec change migrate-pdok-to-openconnector — the procest subset
of the Hydra umbrella shared-pdok-via-openconnector. Replaces direct calls
to api.pdok.nl with calls through /index.php/apps/openconnector/api/pdok/*.
- src/services/pdokService.js — rewrites as a thin shim. All six exported
functions (suggest, lookup, free, reverse, extractCoordinates, formatAddress)
keep their original signatures so existing callers
(src/store/modules/gis.js, src/components/map/AddressSearch.vue) do not change.
- Degraded paths handled gracefully:
503 (PDOK unavailable / circuit open) → resolves with null, surfaces
message_key via module-level `lastWarning`.
404 (openconnector not installed) → resolves with empty result and
a non-blocking warning; form submission unaffected.
- extractCoordinates accepts both the canonical normalized PostalAddress
shape (location.coordinates = [lng, lat]) and raw PDOK WKT.
Per ADR-022 procest no longer talks to api.pdok.nl directly. All PDOK access
flows through openconnector's PdokConnector + write-through to OR's addresses
register.
PR-3 (E2E verification) and PR-4 (test fixtures bootstrap) require the live
dev environment and are deferred until openconnector ConductionNL/openconnector#752
is installed. Tasks PR-1.1, PR-1.2, PR-1.3, PR-2.1 marked done.
Implements #404
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 5% (21 tests / 456 specs)
Quality workflow — 2026-05-11 21:45 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements migrate-pdok-to-openconnector — the procest subset of
shared-pdok-via-openconnector.What
src/services/pdokService.jsrewritten as a thin shim: all PDOK access now flows through/index.php/apps/openconnector/api/pdok/*instead of direct browser calls toapi.pdok.nl.src/store/modules/gis.jsandsrc/components/map/AddressSearch.vueunchanged.message_keyfor display; 404 (openconnector absent) → empty result + non-blocking warning; form submission unaffected.Dependencies
Depends on openconnector#752 (PDOK adapter PR). Functional E2E testing (PR-3) and fixture bootstrap (PR-4) deferred until openconnector is installed.
Test plan
api.pdok.nl)Closes #404.