feat: Tier-4 shell — manifest.json + CnAppRoot (closes #17)#20
Merged
Conversation
OpenBuilt now eats its own dog food: instead of a hand-rolled NcContent + MainMenu.vue + vue-router shell, it declares src/manifest.json and mounts @conduction/nextcloud-vue's CnAppRoot — the same renderer it drives for the virtual apps it builds (ADR-024). - src/manifest.json: menu (Dashboard / Virtual apps / Schemas / Exports / Documentation) + pages. OpenBuilt's pages are tooling UIs, not generic register CRUD, so each is type:"custom" and resolves a view via customComponents — Dashboard, the virtual-app manager (list + detail + Editor/History/Diff tabs), the schema designer (/builder/:slug/schemas + a paramless /schemas shortcut defaulting to the hello-world seed), the export-jobs list, and the BuilderHost virtual-app host. dependencies: ["openregister"] drives CnAppRoot's dependency-check phase (the old "OpenRegister is required" empty state moves to the #dependency-missing slot). - src/customComponents.js: the registry mapping the five custom pages to src/views/*.vue. - src/App.vue: thin CnAppRoot wrapper (manifest / customComponents / pageTypes / translate / permissions) — no more bespoke chrome. - src/main.js: builds the vue-router config from manifest.pages (routesFromManifest), registerIcons() / registerTranslations(), fire-and-forget loadTranslations, mounts App.vue. Deletes src/router/index.js and src/navigation/MainMenu.vue. - SchemaDesigner.appSlug now falls back to 'hello-world' for the paramless /schemas shortcut. - tests/vitest/manifest.spec.js: structural manifest checks (menu→page, custom-page→customComponent, no dead registry entries). Stub extended with the manifest-renderer family. 84 Vitest tests pass. Verified in the dev container: /apps/openbuilt/, /applications, /schemas, /exports all render through CnPageRenderer with the manifest-driven CnAppNav. Supersedes the competing editor shells in #4/#8 (their PageDesigner / templates-gallery become customComponents in a follow-up).
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 430/430 | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/19 statements)
Quality workflow — 2026-05-12 09:21 UTC
Download the full PDF report from the workflow artifacts.
This was referenced May 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
What
OpenBuilt's own app shell becomes manifest-driven (ADR-024 Tier-1+) — the same
CnAppRoot/CnPageRenderersystem it drives for the virtual apps it builds, instead of the hand-rolledNcContent+MainMenu.vue+vue-routerchrome.src/manifest.json—menu(Dashboard / Virtual apps / Schemas / Exports / Documentation) +pages. OpenBuilt's pages are tooling UIs, not generic register CRUD, so each istype: "custom"resolving a view viacustomComponents: Dashboard, the virtual-app manager (ApplicationEditor— list + detail + Editor/History/Diff tabs + RBAC modal + export), the schema designer (/builder/:slug/schemas[/:schemaId]plus a paramless/schemasshortcut), the export-jobs list, theBuilderHost.dependencies: ["openregister"]drives CnAppRoot's dependency-check phase.src/customComponents.js— registry mapping the five custom pages →src/views/*.vue.src/App.vue— thinCnAppRootwrapper; the old "OpenRegister is required" empty state moves to the#dependency-missingslot.src/main.js— builds the vue-router config frommanifest.pages(routesFromManifest),registerIcons()/registerTranslations(), fire-and-forgetloadTranslations, mounts App.vue. Deletessrc/router/index.jsandsrc/navigation/MainMenu.vue.SchemaDesigner.appSlugfalls back tohello-worldfor the paramless/schemasshortcut.tests/vitest/manifest.spec.js— structural checks (menu→page, custom-page→customComponent, no dead registry entries). Stub extended with the manifest-renderer family.Verification
Dev container:
/apps/openbuilt/,/applications,/schemas,/exportsall render throughCnPageRendererwith the manifest-drivenCnAppNavsidebar (screenshots in the issue). 84 Vitest tests pass;eslint srcclean; production build OK. PHPUnit/Newman CI reds are pre-existing (#11).Follow-ups
PageDesigner/ sub-editors and templates-gallery will land ascustomComponents/ aTemplatespage in a follow-up, and feat(openspec): openbuilt-page-editor — visual manifest designer (chain spec #5) #4/spec(openbuilt-templates-marketplace): starter template gallery + clone-from-template (#8/9) #8 close then.templates/index.phpcarries a temporary cache-busting script name (no?v=hash is emitted forjs/openbuilt-main.js) — the repo'stemplates/index.phpis unchanged; consider adding a real cache-buster.