Extra styling for the login page #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add file-level docblocks with license URL to all PHP classes - Add complete method docblocks with @param and @return tags - Fix @AuthorizedAdminSetting annotation placement (after @param tags) - Fix indentation and spacing to match Nextcloud coding standards - All PHPCS errors resolved (exit code 0)
- Toggle between icons and text labels in app menu - Center text labels vertically and horizontally - Remove Nextcloud default active indicator - Clean up CSS specificity - Version bump to 0.1.1-unstable.3
- Add npm run lint script that explains nldesign is CSS/PHP only - This allows CI/CD pipelines to pass linting checks
- Update build-fonts.js to copy actual font files from node_modules - Remove webpack aliases (@import url('~@fontsource...')) from fonts.css - Use relative paths to local font files (fonts/fira-sans-*.woff2) - Bump version to 0.1.1-unstable.4 to invalidate cache - Fixes MIME type errors and 404s for font files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.