ci(release): use --legacy-peer-deps for npm ci#149
Merged
Conversation
The current root devDependencies pin eslint-plugin-jsdoc ^62.9.0 but @nextcloud/eslint-config@8.4.2 declares a peer of ^46.2.6. npm ci is strict and refuses the resolution; npm install --legacy-peer-deps is how the rest of the codebase handles this conflict locally. Bringing the workflow in line so the release run can complete.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
|
🎉 This PR is included in version 1.0.0-beta.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
rubenvdlinde
added a commit
that referenced
this pull request
May 9, 2026
PR #149 added `--legacy-peer-deps` to release.yml's npm ci to skip the npm 11 peer-dep ERESOLVE failure on @vue/eslint-config-typescript. Code Quality (which gates PR merges) was missed and still uses bare `npm ci`, so any new PR fails Frontend Quality with the same conflict the release flow already works around. Bring code-quality.yml in line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release workflow fails at
npm cibecauseeslint-plugin-jsdoc ^62.9.0(root) and^46.2.6(peer of@nextcloud/eslint-config@8.4.2) conflict, andnpm ciis strict by default. Using--legacy-peer-depsbrings the workflow in line with how local dev handles the same conflict.Without this fix, beta-channel publishes are blocked. Run #25600382893 (PR #144 release) failed at this step.
Changes
.github/workflows/release.yml— bothnpm ciinvocations gain--legacy-peer-deps