Skip to content

feat: Add CnObjectSidebar component to App.vue#99

Closed
rubenvdlinde wants to merge 2 commits into
developmentfrom
feature/98/cn-object-sidebar
Closed

feat: Add CnObjectSidebar component to App.vue#99
rubenvdlinde wants to merge 2 commits into
developmentfrom
feature/98/cn-object-sidebar

Conversation

@rubenvdlinde
Copy link
Copy Markdown
Contributor

Summary

  • Integrates CnObjectSidebar from @conduction/nextcloud-vue into the root App.vue layout
  • Adds reactive objectSidebarState via Vue.observable() with provide/inject so child components can open the shared object sidebar
  • Sidebar renders conditionally when objectSidebarState.active is true

Closes #98

Test plan

  • Verify the app loads without errors (npm run dev, check browser console)
  • Inject objectSidebarState in a child component, set active: true with valid register/schema/objectId, and confirm the sidebar opens
  • Confirm sidebar closes when open is set to false
  • Verify no regressions in existing sidebar functionality (SideBars component)

Integrate the shared CnObjectSidebar from @conduction/nextcloud-vue into
the root layout. Uses Vue.observable() for reactive state and provide/inject
so any child component can control the object sidebar.

Closes #98
@github-actions
Copy link
Copy Markdown
Contributor

Quality Report

Repository ConductionNL/docudesk
Commit fffd930
Branch 99/merge
Event pull_request
Generated 2026-03-25 12:19 UTC
Workflow Run https://github.com/ConductionNL/docudesk/actions/runs/23540534650

Summary

Group Result
PHP Quality FAIL
Vue Quality FAIL
Security FAIL
License PASS
PHPUnit SKIP
Newman SKIP
Playwright SKIP

PHP Quality

Tool Result
lint PASS
phpcs FAIL
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint FAIL
stylelint FAIL

Security

Ecosystem Result
composer PASS
npm FAIL

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (111 total)

Metric Count
Approved (allowlist) 111
Approved (override) 0
Denied 0

npm dependencies (311 total)

Metric Count
Approved (allowlist) 310
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.

E2E Tests (Playwright)

Playwright E2E tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

@github-actions
Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/docudesk @ 5463a99

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer ✅ 108/108
npm ✅ 529/529
PHPUnit
Newman ⏭️
Playwright ⏭️

Coverage: 0% (0/10 statements)


Quality workflow — 2026-05-19 03:57 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
Copy link
Copy Markdown
Contributor Author

Closing — rebase blocked. After #211 (manifest-v2 adoption), src/App.vue was fully restructured around CnAppRoot with named slots. This PR's 31-line addition no longer fits as a plain rebase — it needs to be re-authored against the new shell (add CnObjectSidebar inside the #sidebar slot, lift the observable state into the new App data shape). Please reopen as a fresh small PR against post-manifest development if still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant