docs(audit): signing-audit migration plan (closes #131)#133
Open
rubenvdlinde wants to merge 1 commit into
Open
docs(audit): signing-audit migration plan (closes #131)#133rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…roval Implements migrate-signing-audit-to-or-audit — adoption-only scope. SigningAuditService exists with VALID_ACTIONS = [CREATED, SIGNED, ...]. Clean migration to AuditTrailMapper::createAuditTrailEntry requires constructor injection + method body rewrite + ObjectEntity resolution from string IDs. That ObjectEntity resolution naturally lives in the signing approval-workflow migration. This PR records the umbrella rule + plan so signing audit ships alongside the approval-workflow change. Closes #131
Contributor
Quality Report — ConductionNL/docudesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 529/529 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/10 statements)
Quality workflow — 2026-05-11 22:03 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adoption-only. SigningAuditService needs ObjectEntity resolution that naturally lives in signing approval-workflow migration. Records the rule + plan; implementation ships alongside the approval-workflow PR. Closes #131.