fix: align webpack config and sidebar with shared patterns#37
Open
rubenvdlinde wants to merge 5 commits into
Open
fix: align webpack config and sidebar with shared patterns#37rubenvdlinde wants to merge 5 commits into
rubenvdlinde wants to merge 5 commits into
Conversation
- Extend base webpack config instead of replacing resolve/module - Add NodePolyfillPlugin for process polyfill compatibility - Add CnObjectSidebar + objectSidebarState for proper sidebar positioning - Follows ADR-017 (component composition) and ADR-018 (header actions)
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-15 07:57 UTC
Download the full PDF report from the workflow artifacts.
- webpack.config.js: disable splitChunks (NC serves chunks from wrong path), add SCSS rule, use NodePolyfillPlugin, extend base config not overwrite - router/index.js: static imports instead of lazy import() — prevents ChunkLoadError from /apps/ vs /custom_apps/ path mismatch - main.js: remove loadTranslations wrapper (blocks mount on l10n 404), use direct t/n imports matching procest pattern - package.json: upgrade @nextcloud/l10n ^2→^3.4.1, @conduction/nextcloud-vue beta.3→beta.7, fix apexcharts override ^3.45.0
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-15 09:59 UTC
Download the full PDF report from the workflow artifacts.
- Replace custom HTML dashboard with CnDashboardPage component - KPI cards use CnStatsBlock with proper grid layout (4 cols each) - Move 'Bekijk alle' links to widget header-actions - Consistent with Procest/Pipelinq dashboard patterns
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-15 11:43 UTC
Download the full PDF report from the workflow artifacts.
…Settings - router: replaced SettingsView with AdminRoot (same component used by NC admin panel at /settings/admin/decidesk), keeping both surfaces in sync - MainMenu: wrapped Settings link in NcAppNavigationSettings (gear icon widget) matching the Nextcloud UX convention for admin-only controls
Correct Nextcloud settings pattern (matching OpenCatalogi): - Admin config: /settings/admin/decidesk (NC admin panel via AdminSettings.php) - In-app settings: NcAppSettingsDialog modal from gear menu - Gear foldout (NcAppNavigationSettings) holds admin items + Settings - Settings click emits @open-settings, App.vue opens UserSettings modal - Removed /settings route from Vue router
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webpackConfig.resolveandwebpackConfig.moduleNodePolyfillPlugin@4.0.0forprocesspolyfill compatibilityCnObjectSidebar+objectSidebarStateprovide/inject for proper Nextcloud sidebar positioningWhy
All Conduction apps should follow the same webpack and sidebar patterns as OpenCatalogi (the reference implementation). See ADR-017 and ADR-018.