chore: remove dead custom Vue components (AmendmentList, GlobalSearch, MeetingLifecycle)#188
Open
rubenvdlinde wants to merge 1 commit into
Open
chore: remove dead custom Vue components (AmendmentList, GlobalSearch, MeetingLifecycle)#188rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…, MeetingLifecycle) These three components under src/components/ are not imported by anything (verified across src/, lib/, appinfo/, templates/, tests/ — the only remaining references were two stale comments in src/store/store.js describing the #162 store-migration history, now updated, and the unrelated `testMeetingLifecycleEnum` schema test). They were superseded during the manifest-v1 migration (AmendmentList → MotionAmendmentsTab sidebar tab; GlobalSearch → CnAppRoot's built-in nav search). Removing them drops 686 lines of dead custom frontend code with no behavior change — decidesk's only remaining `type: "custom"` page is LiveMeeting (realtime, no declarative analogue) and the 9 detail-tab components, both intentional per openspec/changes/decidesk-manifest-v1/design.md. Purely subtractive: no imports removed, no API surface touched.
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 471/471 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/115 statements)
Quality workflow — 2026-05-12 17:18 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These three components under
src/components/are imported by nothing — verified acrosssrc/,lib/,appinfo/,templates/,tests/. The only remaining references were two stale comments insrc/store/store.jsdescribing the #162 store-migration history (now updated) and the unrelatedtestMeetingLifecycleEnumschema test.They were superseded during the manifest-v1 migration:
AmendmentList→MotionAmendmentsTabsidebar tabGlobalSearch→CnAppRoot's built-in nav searchMeetingLifecycle→ folded intoMeetingDetail/MeetingLifecyclelib panelRemoving them drops 686 lines of dead custom frontend code with no behavior change. Decidesk's only remaining
type:"custom"page isLiveMeeting(realtime, no declarative analogue) and the 9 detail-tab components — both intentional peropenspec/changes/decidesk-manifest-v1/design.md.Purely subtractive: no imports removed, no API surface touched, no manifest change.