feat: meeting integrations surface via the pluggable integration registry (ADR-019)#184
Merged
Merged
Conversation
…stry (ADR-019) Adopts OpenRegister's pluggable integration registry (ConductionNL/openregister#1307) in decidesk: - main.js: installIntegrationRegistry() + registerBuiltinIntegrations() + registerXwikiIntegration() at bootstrap, so the registry is populated before any page mounts. - App.vue: the #sidebar-slot CnObjectSidebar now binds :use-registry and :exclude-integrations from objectSidebarState (the channel CnDetailPage pushes to), plus :custom-components; objectSidebarState gains useRegistry/excludeIntegrations. - New custom view MeetingIntegrations.vue (route /meetings/:id/integrations, registered in customComponents.js): a CnDetailPage with sidebar.useRegistry: true, so the host CnObjectSidebar renders one tab per registered integration provider — the built-in core tabs (Files / Notes / Tags / Tasks / Audit trail) plus the xWiki "Articles" leaf. - manifest.json: adds the MeetingIntegrations page entry. Verified locally against the integration-registry branches: the page renders, the sidebar shows all six tabs, and the Articles tab degrades to the AD-23 "reconnect connector" banner when the OpenConnector xwiki source isn't resolvable. Depends on the @conduction/nextcloud-vue pluggable-integration-registry stack (nextcloud-vue#202..#218) shipping a beta; until then the registry exports won't resolve against beta-30 and this PR stays in draft.
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 471/471 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/115 statements)
Quality workflow — 2026-05-12 12:43 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adopts OpenRegister's pluggable integration registry (ConductionNL/openregister#1307, ADR-019) in decidesk and adds a
MeetingIntegrationssurface that demonstrates it end-to-end.src/main.js—installIntegrationRegistry()+registerBuiltinIntegrations()+registerXwikiIntegration()at bootstrap, so the registry is populated before any page mounts.src/App.vue— the#sidebar-slot<CnObjectSidebar>now binds:use-registryand:exclude-integrationsfromobjectSidebarState(the channelCnDetailPagepushes to), plus:custom-components;objectSidebarStategainsuseRegistry/excludeIntegrations.src/views/MeetingIntegrations.vue(new) — a thinCnDetailPagewrapper withsidebar: { register: 'decidesk', schema: 'meeting', useRegistry: true }. The host<CnObjectSidebar>then renders one tab per registered integration provider: the built-in core tabs (Files / Notes / Tags / Tasks / Audit trail) plus the xWiki "Articles" leaf. Registered incustomComponents.js, routed from the manifest at/meetings/:id/integrations.src/manifest.json— adds theMeetingIntegrationspage entry.Verification
Built against the local
@conduction/nextcloud-vueintegration-registry branch and deployed to the dev Nextcloud:/meetings/:id/integrationspage renders.xwikileaf appears alongside the built-ins).xwikisource isn't resolvable (here, blocked by SourceMapper::find() crashes on non-numeric string lookups (Postgres: invalid input syntax for type bigint) openconnector#755 —SourceMapper::find()crashes on slug lookups on Postgres).Why draft
Depends on the
@conduction/nextcloud-vuepluggable-integration-registry stack (nextcloud-vue#202..#218) shipping a beta. Until that lands, the new registry exports (installIntegrationRegistry,registerBuiltinIntegrations,registerXwikiIntegration,CnObjectSidebarregistry mode,CnDetailPagesidebar.useRegistry) don't exist inbeta-30, sonpm ci+ build will fail in CI. Once the stack publishes, bump@conduction/nextcloud-vue+ the lockfile and mark ready.Related: ConductionNL/openregister#1307 (umbrella), ConductionNL/openregister#1326 (xWiki leaf), ConductionNL/openconnector#755 (the Postgres
find()bug surfaced here).