Skip to content

Release: CNAME fix for www.conduction.nl + accumulated dev#13

Merged
rubenvdlinde merged 2 commits into
mainfrom
development
Apr 29, 2026
Merged

Release: CNAME fix for www.conduction.nl + accumulated dev#13
rubenvdlinde merged 2 commits into
mainfrom
development

Conversation

@rubenvdlinde
Copy link
Copy Markdown
Collaborator

Summary

  • Brings static/CNAME fix from fix: set Pages CNAME to www.conduction.nl #12 onto main so Deploy to GitHub Pages runs with the correct CNAME (www.conduction.nl).
  • Also includes any accumulated commits on development since main last shipped (yesterday).

Without this merge the Pages artifact keeps shipping CNAME=docs.conduction.nl, which prevents Let's Encrypt cert issuance for www.conduction.nl.

Test plan

  • After merge, Deploy to GitHub Pages workflow run on main succeeds
  • gh api repos/ConductionNL/conduction-website/pages shows https_certificate.state == "approved" for www.conduction.nl
  • https://www.conduction.nl/ returns 200 with valid TLS cert

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@rubenvdlinde rubenvdlinde merged commit 70b363f into main Apr 29, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants