issue_498 #499
Closed
issue_498 #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add condition to check if nfs_volumes is defined before mounting shares.
mboisson
reviewed
Jan 19, 2026
| $nfs_volumes = $instances.dig($nfs_server, 'volumes', 'nfs') | ||
| $shares_to_mount = keys($nfs_volumes) + $share_names | ||
| if $nfs_volumes != undef { | ||
| $shares_to_mount = keys($nfs_volumes) + $share_names |
Member
There was a problem hiding this comment.
hum, this still does the keys(...) + $share_names even if it's undef.
And it discards $share_names if it's undef.
Member
There was a problem hiding this comment.
As @mboisson said, $shares_to_mount initialization needs to be based on wether nfs_volumes is undef or not.
if $nfs_volumes != undef {
$shares_to_mount = keys($nfs_volumes) + $share_names
} else {
$shares_to_mount = $share_names
}
I am digging if I can come up with a one-liner, but this works.
Member
There was a problem hiding this comment.
Maybe something like
$shares_to_mount = $nfs_volume != undef ? { keys($nfs_volumes) + $share_names, $share_names }
Member
Author
There was a problem hiding this comment.
$shares_to_mount = keys($nfs_volumes)
if $nfs_volumes != undef {
$shares_to_mount = keys($nfs_volumes) + $share_names
}
Is default and if ok with you @cmd-ntrf ?
Member
|
This relates to #498 |
Member
|
Superseded by PR #500. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add condition to check if nfs_volumes is defined before mounting shares.