Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1373 +/- ##
========================================
Coverage 90.21% 90.21%
========================================
Files 135 135
Lines 14658 14658
========================================
Hits 13223 13223
Misses 1435 1435 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
lol, this pr installed the old packages into the fresh CI envs and is failing because now both versions are installed. I'll need to fix the environments again. Please update your branches before you push them. |
garrettwrong
left a comment
There was a problem hiding this comment.
So long as you feel that simulated image is realistic enough to capture all the behaviors we might want to test now and in the future... this is good, thanks for removing.
Ok, made one small change so the image is not symmetric. Realized that one of the tests is flipping the image along axes and in some cases the flipped image is |
|
We can go ahead an merge this one when you are ready. Thanks |
Remove scipy's
faceimage from testing in favor of a generated image.facewith generated image in test_image.pyfacein test_starfileio.py, along with other unused codefacein a gallery tutorialResolves #1372