Skip to content

Remove scipy face dataset from testing#1373

Merged
j-c-c merged 4 commits intodevelopfrom
remove_face
Mar 30, 2026
Merged

Remove scipy face dataset from testing#1373
j-c-c merged 4 commits intodevelopfrom
remove_face

Conversation

@j-c-c
Copy link
Copy Markdown
Collaborator

@j-c-c j-c-c commented Mar 26, 2026

Remove scipy's face image from testing in favor of a generated image.

  1. Replaced face with generated image in test_image.py
  2. Removed unused import of face in test_starfileio.py, along with other unused code
  3. There is still one remaining use of face in a gallery tutorial

Resolves #1372

@j-c-c j-c-c self-assigned this Mar 26, 2026
@j-c-c j-c-c added CI Continuous Integration cleanup labels Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.21%. Comparing base (921de02) to head (3d07836).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1373   +/-   ##
========================================
  Coverage    90.21%   90.21%           
========================================
  Files          135      135           
  Lines        14658    14658           
========================================
  Hits         13223    13223           
  Misses        1435     1435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong
Copy link
Copy Markdown
Collaborator

lol, this pr installed the old packages into the fresh CI envs and is failing because now both versions are installed. I'll need to fix the environments again. Please update your branches before you push them.

garrettwrong
garrettwrong previously approved these changes Mar 30, 2026
Copy link
Copy Markdown
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as you feel that simulated image is realistic enough to capture all the behaviors we might want to test now and in the future... this is good, thanks for removing.

@j-c-c
Copy link
Copy Markdown
Collaborator Author

j-c-c commented Mar 30, 2026

So long as you feel that simulated image is realistic enough to capture all the behaviors we might want to test now and in the future... this is good, thanks for removing.

Ok, made one small change so the image is not symmetric. Realized that one of the tests is flipping the image along axes and in some cases the flipped image is allclose to the original image (probably not a great characteristic for testing).

@j-c-c j-c-c marked this pull request as ready for review March 30, 2026 14:51
@j-c-c j-c-c requested a review from janden as a code owner March 30, 2026 14:51
Copy link
Copy Markdown
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@garrettwrong
Copy link
Copy Markdown
Collaborator

We can go ahead an merge this one when you are ready. Thanks

@j-c-c j-c-c merged commit 09e8301 into develop Mar 30, 2026
54 of 55 checks passed
@j-c-c j-c-c deleted the remove_face branch March 30, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants