[Web Import] Web import error Banners#999
Conversation
|
I just checked the video. Perhaps we should hide the animated border for items in case of errors? Overall nice improvement! 🔥 |
WalkthroughThis change introduces error banner support for the web import feature in the IDE plugin. A new 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ah yeah, I think that makes sense. Will add that |
fb01344 to
da62f8b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/StandardImportScreenUI.kt`:
- Around line 95-97: The handler for StandardIconEvent.IconDownloadFailed is
clearing selectedIcon unconditionally, allowing stale failures to clear a newer
selection; update the event type to include the icon identity (e.g., add an id
or URL field to IconDownloadFailed) and then, inside the
StandardIconEvent.IconDownloadFailed branch, compare the event's icon identity
against the current selectedIcon before setting selectedIcon = null and showing
the banner; alternatively, change the download flow to use a coroutine operator
like collectLatest/flatMapLatest so only the latest download result is delivered
(adjust code around downloadJob?.cancel(), the download coroutine, and the
StandardIconEvent handling to match the chosen approach).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d407953f-8982-4f9c-ae0c-75f19a881c64
📒 Files selected for processing (9)
tools/idea-plugin/CHANGELOG.mdtools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/jewel/banner/BannerHost.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/jewel/banner/BannerMessage.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/StandardIconViewModel.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/StandardImportScreenUI.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/WebFailureReason.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/WebIconViewModel.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/common/SvgImportScreenUI.kttools/idea-plugin/src/main/resources/messages/Valkyrie.properties
Screen.Recording.2026-05-05.at.22.19.32.mov
Screen.Recording.2026-05-06.at.16.42.25.mov
📝 Changelog
If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs: