Use t.Error instead of t.Fatal for assertion checking #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests will fail if there are any discrepancies between the expected cluster state and the observed state. Using t.Fataf() or t.Fatal marks the test as failed, which is what we want, but it also stop execution of the test. Since we have some helper methods that process the mismatched results to generate assertion files and reports, we don't want to completely stop execution so that we can still produce those files. This commit updates those specific parts of the tests to use Error instead of Fatal so we perserve the behavior to mark the test as failed, but continue processing in the test to cleanup and generate reports.
rhmdnd
force-pushed
the
use-error-instead-of-fatal
branch
from
cc23012 to
f24bf03
Compare
JAORMX
approved these changes
Oct 3, 2025
|
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests will fail if there are any discrepancies between the expected
cluster state and the observed state. Using t.Fatalf() or t.Fatal marks
the test as failed, which is what we want, but it also stop execution of
the test. Since we have some helper methods that process the mismatched
results to generate assertion files and reports, we don't want to
completely stop execution so that we can still produce those files.
This commit updates those specific parts of the tests to use Error
instead of Fatal so we perserve the behavior to mark the test as failed,
but continue processing in the test to cleanup and generate reports.