Adding Debian 13 CIS controls to the benchmark#14684
Adding Debian 13 CIS controls to the benchmark#14684scdarva wants to merge 5 commits intoComplianceAsCode:masterfrom
Conversation
|
Hi @scdarva. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| # - l2_server | ||
| # rules: | ||
| # - configure_gpg_key_access | ||
| # status: automated No newline at end of file |
There was a problem hiding this comment.
missing new line character at the end of file
There was a problem hiding this comment.
Thanks for noticing, added it.
Also added more controls. Those that are commented out and have TODO are not implemented, as they need to be implemented later on.
jan-cerny
left a comment
There was a problem hiding this comment.
I think the CI fail is legit, you need to update the product stability data with the CIS reference:
diff --git a/tests/data/product_stability/debian13.yml b/tests/data/product_stability/debian13.yml
index e96a439170..23007ed4bf 100644
--- a/tests/data/product_stability/debian13.yml
+++ b/tests/data/product_stability/debian13.yml
@@ -81,6 +81,7 @@ reference_uris:
app-srg: https://www.cyber.mil/stigs/downloads/?_dl_facet_stigs=application-servers
app-srg-ctr: https://www.cyber.mil/stigs/downloads/?_dl_facet_stigs=app-security
bsi: https://www.bsi.bund.de/SharedDocs/Downloads/EN/BSI/Grundschutz/International/bsi_it_gs_comp_2022.pdf
+ cis: https://www.cisecurity.org/cis-benchmarks/
cis-csc: https://www.cisecurity.org/controls/
cjis: https://www.fbi.gov/file-repository/cjis-security-policy-v5_5_20160601-2-1.pdf
cobit5: https://www.isaca.org/resources/cobit|
Added test adjustment as suggested, had no idea about their functionalities |
Description:
As currently Debian 13 has missing CIS benchmarks from this project, pull request is specifically to add initial set of CIS controls
Rationale:
To start populating Debian 13 CIS controls. Adding them all in one go is a quite of a task, especially as it does require generate new checks
Review Hints: