fix noschedule rules for hcp#13699
Open
sluetze wants to merge 1 commit intoComplianceAsCode:masterfrom
Open
Conversation
|
Hi @sluetze. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sluetze
force-pushed
the
hcp-no-taint-fix
branch
from
257a7a6 to
f12bc08
Compare
|
Code Climate has analyzed commit f12bc08 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.7% (0.0% change). View more on Code Climate. |
sluetze
force-pushed
the
hcp-no-taint-fix
branch
from
f12bc08 to
acf5cd9
Compare
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
Member
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
Member
|
@sluetze Shouldn't the rule on HCP return |
Contributor
Author
Yes it should. I thought, that
would ensure this, but for reasons I could not find out, it doesn't. Neither for the taint rule nor for the three nodes rule. I made a small table which shows all I think it is safe to say, that the Tested with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR rewrites the master_taint_noschedule test in a way that is compatible with Hypershift.
Rationale:
When running the bsi-profile on a hosted cluster in hypershift, the api-checks failed:
thus the whole profile wasnt finishing. By rewriting the check, it executes now on hypershift and on regular clusters.
Review Hints:
hcp