-
Notifications
You must be signed in to change notification settings - Fork 36
CMP-3808: Add test for global proxy env variables (41769) #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@Anna-Koudelkova: This pull request references CMP-3808 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Anna-Koudelkova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Skipping CI for Draft Pull Request. |
03c20d2 to
95cb5c8
Compare
|
🤖 To deploy this PR, run the following command: |
|
🤖 To deploy this PR, run the following command: |
|
@Anna-Koudelkova: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Created using Cursor, originally as a separate test case and additionally as a part of already existing test case TestSingleTailoredPlatformScanSucceeds (chosen randomly as one of the few test cases where the suite gets created and full scan is run)
On a non-proxy cluster this just gets skipped, as expected.
I have tested it on a cluster with proxy (aws-ipi-proxy-fips, created in the PR) and it is passing with the compliance operator pre-installed by the OLM (as I have learned that CO gets the cluster-wide proxy from OLM) . The speed is quick because the CO installation got skipped:
This should be fine I think, as in everyday life the proxy testing part of the test case should just get skipped and in release testing we test with the operator installed from a catalogsource, but I am doing a lot of guessing right here.
The separate test case in the first commit also works on proxy with preinstalled CO by OLM, I am just not sure what is a better solution.
This is passing on cluster with proxy when compliance operator installed by operator-sdk from bundle image as well