Skip to content

Conversation

@Anna-Koudelkova
Copy link
Collaborator

@Anna-Koudelkova Anna-Koudelkova commented Dec 17, 2025

Created using Cursor, originally as a separate test case and additionally as a part of already existing test case TestSingleTailoredPlatformScanSucceeds (chosen randomly as one of the few test cases where the suite gets created and full scan is run)

On a non-proxy cluster this just gets skipped, as expected.

I have tested it on a cluster with proxy (aws-ipi-proxy-fips, created in the PR) and it is passing with the compliance operator pre-installed by the OLM (as I have learned that CO gets the cluster-wide proxy from OLM) . The speed is quick because the CO installation got skipped:

--- PASS: TestSingleTailoredPlatformScanSucceeds (53.47s)
PASS
ok  	github.com/ComplianceAsCode/compliance-operator/tests/e2e/parallel	264.092s

This should be fine I think, as in everyday life the proxy testing part of the test case should just get skipped and in release testing we test with the operator installed from a catalogsource, but I am doing a lot of guessing right here.

The separate test case in the first commit also works on proxy with preinstalled CO by OLM, I am just not sure what is a better solution.

This is passing on cluster with proxy when compliance operator installed by operator-sdk from bundle image as well

@openshift-ci-robot
Copy link
Collaborator

@Anna-Koudelkova: This pull request references CMP-3808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Created with the help of Cursor, currently I am questioning if I cannot just glue the functionality to some already existing test case.

On a non-proxy cluster this just gets skipped, as expected. Proxy cluster is currently in the making to test this on.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Anna-Koudelkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Anna-Koudelkova Anna-Koudelkova changed the title CMP-3808: Add test for global proxy env variables CMP-3808: Add test for global proxy env variables (41769) Dec 17, 2025
@github-actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1032-03c20d2d096c578a84a2c21bcc55310125bbc06a

@github-actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1032-95cb5c872bc4630c398b1e330680f72d7cef76b1

@Anna-Koudelkova Anna-Koudelkova marked this pull request as ready for review December 17, 2025 21:54
@openshift-ci openshift-ci bot requested review from jhrozek and mrogers950 December 17, 2025 21:54
@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2025

@Anna-Koudelkova: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa 95cb5c8 link true /test e2e-rosa
ci/prow/e2e-aws-serial 95cb5c8 link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants