Upgrade WASDK from 1.6 to 1.8 by 0x5bfa · Pull Request #293 · CommunityToolkit/Tooling-Windows-Submodule

0x5bfa · 2025-09-13T16:50:16Z

Closes #292

0x5bfa · 2025-09-13T20:22:34Z

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(186,5): error : There is not enough space on the disk. [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\ProjectTemplate.sln]

The error doesn't make any sense to me.

0x5bfa · 2025-09-13T20:23:51Z

I've copied the changes to WCT and WCT Labs and the solutions were restored successfully.

Avid29 · 2025-09-25T19:33:44Z

I'll take a look

Arlodotexe · 2026-02-19T16:18:22Z

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(186,5): error : There is not enough space on the disk. [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\ProjectTemplate.sln]

The error doesn't make any sense to me.

The "Out of disk space" errors were caused by GitHub changing Actions from under us, this was patched in #296

Arlodotexe · 2026-02-19T16:33:10Z

Hmm, that's new:

"D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\CiTestExp.sln" (default target) (1:2) ->
"D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Tests.Wasdk\CiTestExp.Tests.Wasdk.csproj" (default target) (2:6) ->
(MsixCheckForInvalidCustomBeforeMicrosoftCommonTargets target) -> 
  C:\Users\runneradmin\.nuget\packages\microsoft.windows.sdk.buildtools.msix\1.7.20250829.1\build\Microsoft.Windows.SDK.BuildTools.MSIX.targets(33,5): error : The MSIX build tools use the 'CustomBeforeMicrosoftCommonTargets' MSBuild property to wire up a custom .props file that sets some necessary properties. This .props file does not appear to have been imported correctly. This likely means that someone has also overridden 'CustomBeforeMicrosoftCommonTargets', without ensuring to also chain the import of the previously assigned .props and .targets set to that property. You can use a binlog to learn more about where that assignment was done (set the verbosity to diagnostics, and search for 'reassignment: $(CustomBeforeMicrosoftCommonTargets'). [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Tests.Wasdk\CiTestExp.Tests.Wasdk.csproj]


"D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\CiTestExp.sln" (default target) (1:2) ->
"D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasdk\CiTestExp.Wasdk.csproj" (default target) (3:6) ->
(_ValidatePresenceOfAppxManifestItems target) -> 
  C:\Users\runneradmin\.nuget\packages\microsoft.windows.sdk.buildtools.msix\1.7.20250829.1\build\Microsoft.Windows.SDK.BuildTools.MSIX.Packaging.targets(3024,5): error MSB4062: The "Microsoft.Build.Msix.AppxManifest.WinAppSdkValidateAppxManifestItems" task could not be loaded from the assembly C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.250108002\buildTransitive\..\tools\net472\Microsoft.Windows.SDK.BuildTools.MSIX.dll. Could not load file or assembly 'file:///C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.250108002\tools\net472\Microsoft.Windows.SDK.BuildTools.MSIX.dll' or one of its dependencies. The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasdk\CiTestExp.Wasdk.csproj]

Errors from the latest CI run.

I notice it's coming from C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.250108002\buildTransitive\..\tools\net472\Microsoft.Windows.SDK.BuildTools.MSIX.dll., so there might still be a version number to update somewhere.

We don't depend on Win2D here, but it might be coming from Behaviors.

Arlodotexe · 2026-02-19T17:25:04Z

Behaviors was updated with Wasdk 1.8 last month and the update is available on NuGet, so we'll update that and see if the error goes away.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

michael-hawker · 2026-03-24T18:00:56Z

@Arlodotexe we should be able to move this along now that Win2D has updated. Can we get test PRs open on the main and labs repo for this too?

…ix build errors

…nced transitively from Microsoft.WindowsAppSDK.WinUI

See also CommunityToolkit/Tooling-Windows-Submodule#293

…tools issue

…from working

…ork around slngen issues

Full error text: ``` Microsoft.Build.Exceptions.InternalLoggerException: The build stopped unexpectedly because the "ReusableLogger" logger failed unexpectedly during shutdown. ---> System.ObjectDisposedException: Cannot write to a closed TextWriter. at System.IO.__Error.WriterClosed() at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder) at Microsoft.Build.Framework.BuildFinishedEventHandler.Invoke(Object sender, BuildFinishedEventArgs e) at Microsoft.Build.Logging.EventArgsDispatcher.Dispatch(BuildEventArgs buildEvent) at Microsoft.VisualStudio.SlnGen.ForwardingLogger.Shutdown() at Microsoft.Build.BackEnd.Logging.LoggingService.ShutdownLogger(ILogger logger) ```

…ution.ps1

…mainline repo

Arlodotexe · 2026-03-30T17:24:47Z

I managed to produce the binlog for this error we were getting:

The MSIX build tools use the 'CustomBeforeMicrosoftCommonTargets' MSBuild property to wire up a custom .props file that sets some necessary properties. This .props file does not appear to have been imported correctly. This likely means that someone has also overridden 'CustomBeforeMicrosoftCommonTargets', without ensuring to also chain the import of the previously assigned .props and .targets set to that property. You can use a binlog to learn more about where that assignment was done (set the verbosity to diagnostics, and search for 'reassignment: $(CustomBeforeMicrosoftCommonTargets').

Verbosity set to diagnostic (as suggested by the error), we're not seeing anything for this reassignment in the binlog:

It's unclear why this error is surfacing with no clear path for investigation.

Suggestions welcome.

michael-hawker · 2026-03-30T20:51:49Z

~~@Arlodotexe where's the update to the Win2D version? I don't see that in the changes?~~

NVM, that's the other repos only I guess, so something else here.

…ws-Submodule#293

0x5bfa added 2 commits September 14, 2025 01:48

Bump bump bump

dab6509

Update

d839259

Arlodotexe mentioned this pull request Sep 25, 2025

Upgrade to Windows App SDK 1.8 #292

Open

Merge branch 'main' into wasdk1.8

5d02250

Avid29 mentioned this pull request Sep 25, 2025

Upgrade WASDK from 1.6 to 1.8 CommunityToolkit/Labs-Windows#738

Draft

Arlodotexe self-requested a review February 19, 2026 16:16

Merge branch 'main' into wasdk1.8

8be12ad

Arlodotexe marked this pull request as ready for review February 19, 2026 16:18

Bump Microsoft.Xaml.Behaviors.WinUI.Managed to 3.0.1

8751cc2

Copilot AI review requested due to automatic review settings February 19, 2026 17:41

Copilot started reviewing on behalf of Arlodotexe February 19, 2026 17:42 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Arlodotexe self-assigned this Mar 24, 2026

Arlodotexe added 2 commits March 24, 2026 16:14

Update WASDK version to 1.8.260204000 to match Win2d dependency and f…

06aed5c

…ix build errors

Remove duplicate Microsoft.Web.WebView2 package reference, now refere…

246c51b

…nced transitively from Microsoft.WindowsAppSDK.WinUI

Arlodotexe added a commit to CommunityToolkit/Windows that referenced this pull request Mar 27, 2026

Update tooling to latest 1.8 fixes

2a9fea0

See also CommunityToolkit/Tooling-Windows-Submodule#293

Arlodotexe added 7 commits March 27, 2026 11:56

Enable diagnostics in CI for binlog output to investigate MSIX build …

cd1e677

…tools issue

Fix quoting issue for component path preventing -UseDiagnostics flag …

5fd3712

…from working

Use quotes around componentPath in GenerateSingleSampleHeads.ps1 to w…

1d6f7d9

…ork around slngen issues

Name artifacts uniquely based on job matrix

7cce0a6

Align slngen command formatting with GenerateAllSolution.ps1

eccf488

Add PSNativeCommandArgumentPassing, further align with GenerateAllSol…

5979164

…ution.ps1

Arlodotexe force-pushed the wasdk1.8 branch from cc2ca76 to 5979164 Compare March 30, 2026 16:22

Arlodotexe added 4 commits March 30, 2026 11:30

Align $sdkoptions to GenerateAllSolution.ps1

d92908e

Add matrix multitarget to artifact name to fix conflicts

4a10a43

Add msbuild binlog and diagnostic params, realign artifact name with …

eb04155

…mainline repo

Set MSBUILD_VERBOSITY to diagnostic

acbfbd5

Arlodotexe added a commit to CommunityToolkit/Windows that referenced this pull request Mar 30, 2026

Updated tooling pointer to latest from CommunityToolkit/Tooling-Windo…

089ba3c

…ws-Submodule#293

Arlodotexe mentioned this pull request Mar 30, 2026

Update Microsoft.WindowsAppSDK to 1.8 stable CommunityToolkit/Windows#837

Open

Arlodotexe added a commit to CommunityToolkit/Labs-Windows that referenced this pull request Mar 30, 2026

Updated tooling pointer to latest from CommunityToolkit/Tooling-Windo…

de65e48

…ws-Submodule#293

Arlodotexe mentioned this pull request Mar 30, 2026

Update Microsoft.WindowsAppSDK to 1.8 stable CommunityToolkit/Labs-Windows#790

Open

Bumped Microsoft.Xaml.Behaviors.Uwp.Managed to latest 3.0.1

ffe7fc9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade WASDK from 1.6 to 1.8#293

Upgrade WASDK from 1.6 to 1.8#293
0x5bfa wants to merge 19 commits intoCommunityToolkit:mainfrom
0x5bfa:wasdk1.8

0x5bfa commented Sep 13, 2025

Uh oh!

0x5bfa commented Sep 13, 2025

Uh oh!

0x5bfa commented Sep 13, 2025

Uh oh!

Avid29 commented Sep 25, 2025

Uh oh!

Arlodotexe commented Feb 19, 2026

Uh oh!

Arlodotexe commented Feb 19, 2026 •

edited

Loading

Uh oh!

Arlodotexe commented Feb 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

michael-hawker commented Mar 24, 2026 •

edited

Loading

Uh oh!

Arlodotexe commented Mar 30, 2026

Uh oh!

michael-hawker commented Mar 30, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

0x5bfa commented Sep 13, 2025

Uh oh!

0x5bfa commented Sep 13, 2025

Uh oh!

0x5bfa commented Sep 13, 2025

Uh oh!

Avid29 commented Sep 25, 2025

Uh oh!

Arlodotexe commented Feb 19, 2026

Uh oh!

Arlodotexe commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Arlodotexe commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

michael-hawker commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Arlodotexe commented Mar 30, 2026

Uh oh!

michael-hawker commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Arlodotexe commented Feb 19, 2026 •

edited

Loading

Arlodotexe commented Feb 19, 2026 •

edited

Loading

michael-hawker commented Mar 24, 2026 •

edited

Loading

michael-hawker commented Mar 30, 2026 •

edited

Loading