feat: upgrade to support SurrealDB v3#1294
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1294Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1294" |
|
We've got some merge conflicts @Odonno which is because of the OTEL packages - if you can fix those, when CI goes green it should auto-merge |
There was a problem hiding this comment.
Pull request overview
This PR updates the SurrealDB integration in the Aspire Community Toolkit to support SurrealDB v3, adjusting both the hosting container defaults and the sample/test code to work with newer SurrealDb.* client/minimal-API packages.
Changes:
- Bumped SurrealDB/Surrealist container image tags and upgraded
SurrealDb.Net/SurrealDb.MinimalApis.Extensionspackage versions. - Updated the SurrealDB example API to use the newer Minimal APIs endpoint mapping with session type and adjusted initialization flow.
- Updated centralized OpenTelemetry package versions/pins (with some instrumentation packages explicitly pinned).
Show a summary per file
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.SurrealDb.Tests/AppHostTests.cs | Reorders API calls so DB initialization happens before querying endpoints. |
| src/CommunityToolkit.Aspire.SurrealDb/SurrealDbClientSettings.cs | Changes default DI lifetime to Scoped and updates corresponding XML doc. |
| src/CommunityToolkit.Aspire.Hosting.SurrealDb/SurrealDbContainerImageTags.cs | Updates default container tags for SurrealDB and Surrealist. |
| examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/Program.cs | Updates example endpoints and DB initialization logic for new SurrealDb packages. |
| examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/Models/WeatherForecastFaker.cs | Improves XML doc wording and removes redundant constructor comment. |
| examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/Models/WeatherForecast.cs | Adds table/column mapping attributes. |
| examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/Models/TodoFaker.cs | Adds faker for Todo sample data. |
| examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/Models/Todo.cs | Adds table/column mapping attributes for Todo. |
| Directory.Packages.props | Upgrades SurrealDb package versions; pins some OpenTelemetry instrumentation versions. |
| Directory.Build.props | Bumps OpenTelemetryVersion property used by centralized package versions. |
Copilot's findings
- Files reviewed: 10/10 changed files
- Comments generated: 4
Head branch was pushed to by a user without write access
6f98ab4 to
9da98ed
Compare
|
@Odonno it seems that the TypeScript AppHost is failing here. The logs are saying that the resource isn't starting, so you might need to run it locally and verify/resolve |
Update SurrealDB integration to support v3:
PR Checklist
Other information