Add support for entity SIDs in entity container whitelists/blacklists#55
Open
earthwise01 wants to merge 1 commit intoCommunalHelper:devfrom
Open
Add support for entity SIDs in entity container whitelists/blacklists#55earthwise01 wants to merge 1 commit intoCommunalHelper:devfrom
earthwise01 wants to merge 1 commit intoCommunalHelper:devfrom
Conversation
earthwise01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, entity containers store their whitelist/blacklist as
List<Tuple<string, int>>s of pairs of short type names and specific indices of that type inside the container to affect.This PR reworks them to use
Dictionary<string, HashSet<int>>s instead to hopefully improve performance for longer lists, and to useEntity.SourceData.Name/EntityRegistry.GetKnownSidsFromTypeto check for the SIDs of entities along with their short type names.The
attachTofield of attached containers has also been updated to support entity SIDs, and all Lönn plugins/tooltips have been updated accordingly.