Skip to content

Simultaneous ADV and NVL text#376

Merged
PringlesGang merged 10 commits intomasterfrom
simul-adv-nvl
Feb 3, 2026
Merged

Simultaneous ADV and NVL text#376
PringlesGang merged 10 commits intomasterfrom
simul-adv-nvl

Conversation

@PringlesGang
Copy link
Copy Markdown
Member

@PringlesGang PringlesGang commented Jan 15, 2026

Primarily mplements the logic necessary for displaying multiple DialoguePages at the same time

  • Properly handle multiple simultaneous DialoguePages
  • Implement InstMessWindow "Ex" type sub-instructions
  • Handle wait icon across multiple DialoguePages
  • Skip mode is noticeably faster now

Fixes #359

I have a much larger DialoguePage rework in the works that would fix a lot more stuff related to text handling (e.g. nametag display, backlog entry insertion, backlog entry rendering, reimplementing InstMes, etc.) but I figured this PR could still merge separately from that

Reference this for the RE-d InstMes and InstMesMain

@PringlesGang PringlesGang added this to the 0.9.X Polishing milestone Jan 15, 2026
@PringlesGang PringlesGang self-assigned this Jan 15, 2026
@PringlesGang PringlesGang force-pushed the simul-adv-nvl branch 3 times, most recently from 4c221e4 to 2cfd87f Compare January 25, 2026 20:29
@PringlesGang PringlesGang marked this pull request as ready for review January 25, 2026 20:49
Copy link
Copy Markdown
Member

@Enorovan Enorovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The effect is properly implemented.

Copy link
Copy Markdown
Contributor

@Gunoshozo Gunoshozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread src/vm/inst_dialogue.cpp
Comment thread src/vm/inst_dialogue.cpp Outdated
Comment thread src/vm/inst_dialogue.cpp Outdated
Comment thread src/vm/inst_dialogue.cpp Outdated
@PringlesGang PringlesGang merged commit a72cd59 into master Feb 3, 2026
15 of 17 checks passed
@PringlesGang PringlesGang deleted the simul-adv-nvl branch February 3, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DialoguePage Refactor Step 1] NVL and ADV at the same time

4 participants