[docs] Fix QuantizedTensor.from_float examples to use layout name strings#43
Open
BhagyeshKothalkar wants to merge 1 commit into
Open
[docs] Fix QuantizedTensor.from_float examples to use layout name strings#43BhagyeshKothalkar wants to merge 1 commit into
BhagyeshKothalkar wants to merge 1 commit into
Conversation
Author
|
@maxious @guill @yoland68 @robinjhuang It is a documentation-only fix to ensure the QuantizedTensor.from_float examples match the current API behavior and avoid lookup errors. The PR is ready, but it appears to be waiting on a workflow approval from a maintainer. Could someone please take a look when you have a moment? Also, please let me know if there is anything else you need from my side to get this merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
QuantizedTensor.from_float(...)examples to match the current API.What changed
TensorCoreFP8Layoutdocstring example to do the sameWhy
QuantizedTensor.from_float(...)currently expectslayout_clsto be the registered layout name string, not the layout class object itself. Internally, the implementation resolves that string through theLAYOUTSregistry incomfy_kitchen.tensor.base. While the codebase and test suite correctly pass this string, the README examples and docstrings pass the layout class object.As a result, passing
TensorCoreFP8Layoutdirectly raises a lookup error, while passing"TensorCoreFP8Layout"works as intended. This PR updates the examples to reflect the behavior implemented by the current API.Scope
Documentation only; no implementation changes.