Skip to content

Removing pypi check_for_updates from commands where it halts offline execution #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jason-weirather wants to merge 3 commits into from
Closed

Removing pypi check_for_updates from commands where it halts offline execution #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9d277c
Fix hang issue in comfy-cli
jason-weirather Sep 7, 2024
7b4982d
remove checks for updates when not updating
jason-weirather Sep 8, 2024
47164c2
these changes were necessary to function offline
jason-weirather Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions comfy_cli/cmdline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
from comfy_cli.constants import GPU_OPTION, CUDAVersion
from comfy_cli.env_checker import EnvChecker
from comfy_cli.standalone import StandalonePython
from comfy_cli.update import check_for_updates
from comfy_cli.workspace_manager import WorkspaceManager, check_comfy_repo

logging.setup_logging()
Expand Down Expand Up @@ -222,7 +221,6 @@ def install(
),
] = False,
):
check_for_updates()
checker = EnvChecker()

comfy_path, _ = workspace_manager.get_workspace_path()
Expand Down Expand Up @@ -496,7 +494,6 @@ def which():
@app.command(help="Print out current environment variables.")
@tracking.track_command()
def env():
check_for_updates()
_env_checker = EnvChecker()
table = _env_checker.fill_print_table()
workspace_manager.fill_print_table(table)
Expand Down
2 changes: 0 additions & 2 deletions comfy_cli/command/launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from comfy_cli import constants, utils
from comfy_cli.config_manager import ConfigManager
from comfy_cli.env_checker import check_comfy_server_running
from comfy_cli.update import check_for_updates
from comfy_cli.workspace_manager import WorkspaceManager, WorkspaceType

workspace_manager = WorkspaceManager()
Expand Down Expand Up @@ -108,7 +107,6 @@ def launch(
background: bool = False,
extra: list[str] | None = None,
):
check_for_updates()
resolved_workspace = workspace_manager.workspace_path

if not resolved_workspace:
Expand Down