Skip to content

chore: improve ComfyUI maintenance path#14138

Open
lphuc2250gma wants to merge 1 commit into
Comfy-Org:masterfrom
lphuc2250gma:maint/20260527122811
Open

chore: improve ComfyUI maintenance path#14138
lphuc2250gma wants to merge 1 commit into
Comfy-Org:masterfrom
lphuc2250gma:maint/20260527122811

Conversation

@lphuc2250gma
Copy link
Copy Markdown

Summary:

  • Add or tighten focused edge-case tests or type assertions in tests/conftest.py, tests/compare/conftest.py related to Python typing, tests, CLI ergonomics, observability; avoid docs-only changes and broad refactors.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 225f0b9d-4d16-4b50-83f9-f642b25bfded

📥 Commits

Reviewing files that changed from the base of the PR and between 53eba22 and ccc841a.

📒 Files selected for processing (2)
  • tests-unit/compare_test/conftest_test.py
  • tests/compare/conftest.py

📝 Walkthrough

Walkthrough

This PR refactors gather_file_basenames in tests/compare/conftest.py to add type safety and stricter error handling. The function now explicitly declares parameter and return types, asserts that input is a string, returns an empty list for missing directories, and filters results to .png files via list comprehension. A new test module introduces comprehensive coverage with three test cases validating .png filtering, missing-directory behavior, and type-validation errors.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: improve ComfyUI maintenance path' is vague and does not clearly describe the specific changes made in this PR. Consider a more specific title that describes the actual changes, such as 'test: add unit tests and type hints for gather_file_basenames' or 'chore: add type hints and edge-case tests for conftest utilities'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, explaining that focused edge-case tests and type assertions are being added to conftest files, which aligns with the actual changes shown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant