fix: Preserve portable Python isolation on restart#13945
Open
Tom-M-Git wants to merge 27 commits into
Open
Conversation
Set environment variables for user profile and cache paths.
Set environment variables for user profile and cache paths before running the Python script.
Set environment variables for user profile and cache directories before running the Python script.
Set environment variables for user profile and cache paths before executing the Python script.
Set environment variables for user profile and cache paths before running the Python script.
Tom-M-Git
requested review from
Kosinkadink,
alexisrolland,
comfyanonymous,
guill,
kijai and
rattus128
as code owners
Removed user profile cache environment variable settings from the script.
Author
|
Updated. Removed cache dir reset code and made code more consistent. Reason:
|
Author
|
Updated. Fixed unused variable. |
Member
|
Tested for the following
|
alexisrolland
previously approved these changes
May 28, 2026
Kosinkadink
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve portable Python isolation by resetting Python-related environment variables and launching Python with
-s.Current issue
The Windows portable build may unintentionally import packages from the user's Python environment (for example
%APPDATA%\Python\Python313\site-packages) during Manager restarts or custom node installation.This can lead to mixed package resolution between the embedded Python environment and user-site packages, causing issues such as mismatched Torch/Torchaudio installations and inconsistent dependency behavior.
Result
The portable build remains isolated from user-site Python packages across startup and Manager-triggered restarts.