fix: pin SQLAlchemy>=2.0 in requirements.txt (CORE-63)#13316
Open
octo-patch wants to merge 1 commit intoComfy-Org:masterfrom
Open
fix: pin SQLAlchemy>=2.0 in requirements.txt (CORE-63)#13316octo-patch wants to merge 1 commit intoComfy-Org:masterfrom
octo-patch wants to merge 1 commit intoComfy-Org:masterfrom
Conversation
📝 WalkthroughWalkthroughThe pull request updates the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13036
Problem
ComfyUI uses SQLAlchemy 2.0-only APIs (DeclarativeBase, mapped_column, Mapped) in app/database/models.py and app/assets/database/models.py. Without a minimum version constraint, pip can resolve SQLAlchemy 1.x, causing an ImportError that crashes startup before any try/except can intercept it.
Solution
Pin SQLAlchemy>=2.0 in requirements.txt to ensure pip installs a compatible version.
Testing
Verified that both app/database/models.py and app/assets/database/models.py use SQLAlchemy 2.0-only APIs (DeclarativeBase, mapped_column, Mapped), and the constraint aligns with what the codebase already requires implicitly.