Use PEP 639 license-files in pyproject.toml#12544
Use PEP 639 license-files in pyproject.toml#12544fecet wants to merge 2 commits intoComfy-Org:masterfrom
Conversation
Replace deprecated `license = { file = "LICENSE" }` with PEP 639
SPDX expression format. The old table-based license field is
deprecated per PEP 639 and causes issues with tools that expect
machine-readable SPDX identifiers (e.g. conda build backends).
Ref: https://peps.python.org/pep-0639/#deprecate-license-field
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2384ced6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughIn 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 5: Update the license identifier in pyproject.toml from "GPL-3.0-only" to
"GPL-3.0-or-later" so it matches the source headers (e.g., files
comfy/controlnet.py, comfy/supported_models_base.py, comfy/utils.py) that state
"either version 3 of the License, or (at your option) any later version"; locate
the license = "..." entry in pyproject.toml and change its value accordingly.
- Around line 5-6: Update the SPDX identifier and add a build-system
requirement: change the project license entry currently set as license =
"GPL-3.0-only" to license = "GPL-3.0-or-later" (the existing license-files =
["LICENSE"] can remain), and add a [build-system] table that pins setuptools to
at least 77 (e.g., requires including "setuptools>=77" and a wheel entry, and
set build-backend to setuptools.build_meta) so PEP 639 features like
project.license and project.license-files are supported.
Leave the SPDX identifier decision to ComfyUI maintainers.
Test Evidence CheckIf this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided. You can add it by:
|
Summary
license = { file = "LICENSE" }withlicense-files = ["LICENSE"](PEP 639)Motivation
PEP 639 deprecates the table-based
licensefield. The old{ file = "..." }format causes issues with tools that expect machine-readable SPDX identifiers (e.g. pixi-build-python).This PR only migrates the file reference syntax. The SPDX
licenseidentifier is left for maintainers to decide if/when needed.Test plan