Skip to content

Fix: Addressed issues for ComfyUI-ACES-EXR-Toolkit#2918

Open
azhagurajpandians wants to merge 1 commit into
Comfy-Org:mainfrom
azhagurajpandians:main
Open

Fix: Addressed issues for ComfyUI-ACES-EXR-Toolkit#2918
azhagurajpandians wants to merge 1 commit into
Comfy-Org:mainfrom
azhagurajpandians:main

Conversation

@azhagurajpandians
Copy link
Copy Markdown

This PR replaces my previous closed PR. I have completely addressed the security issues flagged by the scanner in ComfyUI-ACES-EXR-Toolkit.

Security Fixes Implemented:

  • Removed imageio and imageio[freeimage] from dependencies to prevent any dynamic/unverified C-binary downloads.
  • Removed custom API endpoint /aces-exr/listdir and js/exr_browser.js which were flagged for arbitrary directory browsing/traversal.
  • Secured /nodex_hdr/view endpoint by strictly using os.path.basename() to restrict access only to the temporary directory.
  • Removed all usage of ctypes.
  • Completely transitioned to using ComfyUI's native OpenCV dependency (cv2) for EXR float32 support.

The node is now secure and fully compliant with the registry's safety guidelines. Let me know if there is anything else I need to address!

Add ACES EXR Toolkit to registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant