N°9553 - Fix on LoadLocalizedData in ModuleInstaller

[v-dumas]

Base information

Question	Answer
Related to a Combodo ticket
Type of change?	Bug fix / Enhancement / Translations

Proposed solution (bug and enhancement)

Improve code and tests

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested all changes I made on an iTop instance
• I have added a unit test, otherwise I have explained why I couldn't
• Is the PR clear and detailed enough so anyone can understand without digging in the code?

[greptile-apps]

Greptile Summary

This PR updates localized data loading during module installation. The main changes are:

• LoadLocalizedData() accepts nullable version arguments.
• Empty first-loading versions can force loading on upgrades.
• Localized data now always uses the passed configuration language.
• Missing localized files now flow directly into XMLFileLoad().
• Unit tests were expanded for language fallback, version gates, and invalid parameters.

Confidence Score: 3/5

This should be fixed before merging.

• Missing localized data files can now abort setup instead of being skipped.
• Upgrade paths can load data in the wrong language when the passed configuration differs from the installed configuration.
• The issues affect core module installation and upgrade behavior.

setup/moduleinstaller.class.inc.php

Important Files Changed

Filename	Overview
setup/moduleinstaller.class.inc.php	Changes the localized data loading gate, language source, and missing-file handling.
tests/php-unit-tests/unitary-tests/setup/ModuleInstallerAPITest.php	Adds coverage for language fallback, version conditions, idempotent loading, and invalid parameters.

_{Reviews (1): Last reviewed commit: "N°9553 - fix typo" | Re-trigger Greptile}