Fix bulk modify timeout on AttributeLinkedSetIndirect

sources/Core/AttributeDefinition/AttributeDefinition.php

@@ -373,9 +373,11 @@ public static function IsScalar()
 	 *
 	 * @return bool
 	 * @since 3.1.0 N°3190
-	 *
+	 * @since 3.3.x Changed from static to non-static so that subclasses can decide
+	 *              based on instance-level configuration (e.g. display_style on LinkedSets).
+	 *              Overriding implementations in extensions must drop the `static` modifier.
 	 */
-	public static function IsBulkModifyCompatible(): bool
+	public function IsBulkModifyCompatible(): bool
 	{
 		return static::IsScalar();
 	}

sources/Core/AttributeDefinition/AttributeLinkedSet.php

@@ -64,7 +64,7 @@ public function GetEditClass()
 	}
 
 	/** @inheritDoc */
-	public static function IsBulkModifyCompatible(): bool
+	public function IsBulkModifyCompatible(): bool
 	{
 		return false;
 	}

sources/Core/AttributeDefinition/AttributeLinkedSetIndirect.php

@@ -100,10 +100,18 @@ public function GetMirrorLinkAttribute()
 		return $oRet;
 	}
 
-	/** @inheritDoc */
-	public static function IsBulkModifyCompatible(): bool
+	/**
+	 * Bulk modify is only meaningful for the property-style (tagset-like) widget.
+	 * The tab-style widget cannot be rendered inside the bulk modify form, and
+	 * eagerly materialising large indirect link sets for every selected object
+	 * caused timeouts.
+	 *
+	 * @inheritDoc
+	 * @since 3.3.x
+	 */
+	public function IsBulkModifyCompatible(): bool
 	{
-		return true;
+		return $this->GetDisplayStyle() === LINKSET_DISPLAY_STYLE_PROPERTY;
 	}
 
 }

tests/php-unit-tests/unitary-tests/core/AttributeDefinitionTest.php

@@ -340,4 +340,45 @@ public function GivenAttribute(string $sHostClass, string $sAttCode, string $sAt
 		return $oAttribute;
 	}
 
+	/**
+	 * @dataProvider IsBulkModifyCompatibleProvider
+	 * @covers       \AttributeDefinition::IsBulkModifyCompatible
+	 * @covers       \Combodo\iTop\Core\AttributeDefinition\AttributeLinkedSet::IsBulkModifyCompatible
+	 * @covers       \Combodo\iTop\Core\AttributeDefinition\AttributeLinkedSetIndirect::IsBulkModifyCompatible
+	 *
+	 * Regression test for the bulk modify timeout caused by N°3190: indirect link sets
+	 * displayed as a tab (the default) used to declare themselves bulk-modify-compatible,
+	 * triggering eager materialisation of every link for every selected object. The
+	 * predicate must now depend on the instance-level display_style.
+	 */
+	public function testIsBulkModifyCompatible(string $sClass, string $sAttCode, bool $bExpected): void
+	{
+		$oAttDef = MetaModel::GetAttributeDef($sClass, $sAttCode);
+		$this->assertSame(
+			$bExpected,
+			$oAttDef->IsBulkModifyCompatible(),
+			"IsBulkModifyCompatible() mismatch for $sClass::$sAttCode"
+		);
+	}
+
+	public static function IsBulkModifyCompatibleProvider(): array
+	{
+		return [
+			'Scalar attribute (AttributeString)' => [
+				'UserRequest', 'title', true,
+			],
+			'AttributeLinkedSet (1:n) is never bulk compatible' => [
+				'UserRequest', 'workorders_list', false,
+			],
+			'AttributeLinkedSetIndirect with default (tab) display_style' => [
+				// Regression: must be false to avoid the bulk modify timeout
+				'UserRequest', 'contacts_list', false,
+			],
+			'AttributeLinkedSetIndirect with property display_style' => [
+				// Preserves the N°3190 feature (tagset-like inline editor in bulk form)
+				'FunctionalCI', 'groups_list', true,
+			],
+		];
+	}
+
 }