Patch for RimofTheFallen

[danilosmatos]

Additions

• CE Compatibility to the weapons, armor and helmets in the mod

References

• Closes [Patch Request]: RimOfTheFallen #4257

Reasoning

• The armor is very cool
• The vanilla stats were horribly balanced, and it didn't mesh well with MO
• Also, used the balance from the medieval overhaul patch as reference

Alternatives

• None

Testing

Check tests you have performed:

• Compiles without warnings
• Game runs without errors
• (For compatibility patches) ...with and without patched mod loaded
• Playtested a colony (5 min messing around with the weapons, armours and such)

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23728896633.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23824834361.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23824881880.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23824936443.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23954576467.zip

[N7Huntsman]

The general philosophy for compatibility patches is to patch as few elements as possible to make the items functional and reasonably balanced for the parts that CE's mechanics touch. That being the case, I've got a couple of broad changes I'd like to see:

1. Avoid touching stuff non-combat stats like Insulation_Heat or EquipDelay unless it's necessary--in general, we want to leave as much of the balance as is practical in the hands of the original mod author.
2. For uniformity and readability, please go through and format the patches in line with how we do so in existing patches. Instead of:

	<Operation Class="PatchOperationReplace">
		<xpath>Defs/ThingDef[defName="RofF_Paladin_Armor"]/statBases/WorkToMake</xpath>
		<value><WorkToMake>30000</WorkToMake></value>
	</Operation>

We want:

	<Operation Class="PatchOperationReplace">
		<xpath>Defs/ThingDef[defName="RofF_Paladin_Armor"]/statBases/WorkToMake</xpath>
		<value>
				<WorkToMake>30000</WorkToMake>
		</value>
	</Operation>

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26464103141.zip

[danilosmatos]

Sorry about the earlier messy patches, should have cleaned everything up now, if there's any problem please do send a message