Bring melee stat displays closer to reality

[mszabo-wikia]

Changes

• Patch the MeleeDPS stat to use our StatWorker.
• In StatWorker_MeleeDamageAverage and StatWorker_MeleeArmorPenetration, use the pawn's list of melee verbs when computing the stat for a pawn, since the available verbs impact their weighting relative to each other. For instance, a pawn wielding a club may still choose to fight with fists some % of the time, but won't do so if wielding a masterwork longsword.
• Always obtain melee verbs from VerbUtility.GetAllVerbProperties when computing stats for a single weapon (which may be wielded by a pawn), so that damage, cooldown and tool use chance can be computed via VerbProperties helpers that take stuffing into account.
• Show the chance to use a given tool in the armor penetration stat explainer for clarity.

References

Links to the associated issues or other related pull requests, e.g.

• Closes [Bug]: Material damage factor not taken into account in item preview screen #3937
• Closes [Bug]: Material Melee Cooldown Factor not taken into account in item info cards #3938
• Closes [Bug]:A pawn's melee DPS does not factor in the damage variation dictated by its melee skill #3939
• Closes [Bug]: Ranged Weapons and Prosethetic Things do not show Tool-related stats #4347

Reasoning

Our current melee stat displays leave much to be desired:

• The "Melee DPS" stat shown prominently for pawns is an unpatched vanilla stat, which doesn't take CE's damage scaling into account.
• The stuff a weapon is made of isn't factored into stats, which impacts not just damage and cooldown but also the chance to pick a given tool relative to other tools.
• The armor penetration stat shown for humans doesn't consider the wielded weapon.

Testing

• Compiles without warnings
• Game runs without errors
• Playtested a colony - tested stat displays for various weapons wielded and unwielded.

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20218739883.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20219393637.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20219694945.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20219741861.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20250727555.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20282003141.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-21805020287.zip

[N7Huntsman]

No issues in my testing, but some small potential improvements that could be made:

• If the melee attack doesn't have a sharp AP value, we can probably just list "0" instead of displaying the calculation for the AP value (that amounts to 0 anyway).
• Could hide the 'adjusted for weapon' line in the DPS screen if it's the same as the weapon base damage and/or if it doesn't have quality to factor in (like for natural weapons and implants).
• Could also hide the "damage variation" line if there's no actual variation (this appears to be the case for pawns that don't actually have a Melee skill, like mechs and animals).

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26372266864.zip