fix: correct package name, dependencies, and URL in setup.py#4
Open
haoyu-haoyu wants to merge 1 commit intoCogStack:mainfrom
Open
fix: correct package name, dependencies, and URL in setup.py#4haoyu-haoyu wants to merge 1 commit intoCogStack:mainfrom
haoyu-haoyu wants to merge 1 commit intoCogStack:mainfrom
Conversation
Three critical bugs made the package completely uninstallable: 1. Package name was "medgpt" but the source directory is foresight/ — setuptools could not find any modules to install. 2. Missing comma after 'datasets==2.15.0' caused Python implicit string concatenation, producing the nonsensical requirement 'datasets==2.15.0transformers==4.35.2'. 3. URL pointed to the old repo (github.com/w-is-h/medgpt) instead of github.com/CogStack/Foresight. Additional improvements: - Removed the non-existent foresight.models sub-package (see CogStack#1) - Relaxed version pins (>=X.Y instead of ==X.Y.Z) so the package can coexist with other libraries - Moved flash-attn to extras_require since it requires a CUDA build environment and is not needed for CPU-only usage - Added python_requires=">=3.9" - Added torch and numpy as explicit dependencies (imported by the package but previously missing from install_requires) - Removed unused setuptools command imports - Added encoding="utf-8" to open() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.pyhas three critical bugs that make the package completely uninstallable viapip install -e .orpip install .:Bug 1: Wrong package name
Bug 2: Missing comma causes string concatenation
Bug 3: URL points to old repository
Additional improvements
foresight.modelssub-package (relates to no 'models' provided #1)>=instead of==) for compatibilityflash-attntoextras_require(requires CUDA build env)torchandnumpydependenciespython_requires=">=3.9"Test plan
Partially addresses #1 (the
foresight.modelsmodule is still missing from the repo, but at leastsetup.pyno longer references it).