Skip to content

fix(config): allow version resolution to traverse through .git #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CalvinAllen merged 1 commit into from
Jan 12, 2026
Merged

fix(config): allow version resolution to traverse through .git #196

CalvinAllen merged 1 commit into from
Jan 12, 2026

Conversation

@CalvinAllen
Copy link
Contributor

@CalvinAllen CalvinAllen commented Jan 12, 2026

Summary

  • Remove git root stopping logic from findLocalVersion() and FindLocalRuntimesFile()
  • Update test to verify config files in parent directories are found even when inside a git repository
  • Update CLAUDE.md documentation to reflect new behavior

Test plan

  • All existing unit tests pass
  • New test TestFindLocalRuntimesFile_TraversesThroughGitRoot verifies the fix
  • Manual testing: set local version in parent folder, verify it's used in git repo subfolders

Fixes #195

@CalvinAllen
fix(config): allow local version resolution to traverse through git r…
af4440a 
…oots

Previously, version resolution stopped at .git directories, preventing
local config files in parent directories from being found when inside
a git repository. This caused issues when users set a local version in
a parent folder containing multiple git repos.

Now version resolution continues walking up until a .dtvem/runtimes.json
file is found or the filesystem root is reached.

Fixes #195
@CalvinAllen CalvinAllen changed the title fix(config): allow local version resolution to traverse through git roots fix(config): allow local version resolution to traverse through .git Jan 12, 2026
@CalvinAllen CalvinAllen changed the title fix(config): allow local version resolution to traverse through .git fix(config): allow version resolution to traverse through .git Jan 12, 2026
@CalvinAllen CalvinAllen merged commit 45e842c into main Jan 12, 2026
12 of 16 checks passed
@CalvinAllen CalvinAllen deleted the fix/config/local-version-git-traversal branch January 12, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: git repos ignoring parent folder local setting defaults to global setting

2 participants

@CalvinAllen