fix(gutter): enable mouse events for tooltip #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add transparent background to gutter margin Canvas so mouse events are properly captured. WPF requires a Background to be set for hit-testing to work.
- Remove Git Graph, File History, Line History, Compare commands from menus - Remove Git Graph settings from options page - Keep stub command files for future implementation - Remove unused command ID constants
- Create Git Ranger submenu under Extensions top-level menu - Move Toggle Inline Blame and Toggle Blame Gutter to submenu - Remove "Git Ranger:" prefix from menu items (submenu provides context)
- Replace WPF ToolTip with Popup for reliable dynamic tooltips - Add TextChanges CommandFlag to allow Enable/Disable text updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
Background = Brushes.Transparentto the gutter margin Canvas.In WPF, a Canvas without a Background property set will not receive mouse events in empty areas. This was preventing the tooltip from appearing when hovering over the gutter margin.
Test plan