Skip to content

Conversation

Copy link

Copilot AI commented Dec 6, 2025

The GitHub release workflow needed a reliable way to attach all CLI artifacts from multiple platforms to releases.

Changes

  • Zip the ./artifacts_download directory into cli-artifacts.zip before creating releases
  • Updated gh release create commands in both Github release and Github prerelease steps to attach the zip file
  • Added shell: bash to Github release step for consistency

This ensures all CLI artifacts in nested directories under ./artifacts_download/ are properly captured in a single zip file:

# Create zip of all artifacts
zip -r cli-artifacts.zip ./artifacts_download
gh release create $VERSION ./SkiaSharpCompare/bin/Release/*.*nupkg cli-artifacts.zip --generate-notes

The zip file approach is simpler and more reliable than glob pattern expansion, and provides users with a convenient single download containing all platform-specific CLI binaries.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on diff metadata changes Enable globstar for recursive artifact glob patterns in release workflow Dec 6, 2025
Copilot AI requested a review from stesee December 6, 2025 13:28
@stesee
Copy link

stesee commented Dec 6, 2025

@copilot stop fiddling with lobster
Zip the directory that is tried to use in gh release

Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
Copy link
Author

Copilot AI commented Dec 6, 2025

@copilot stop fiddling with lobster
Zip the directory that is tried to use in gh release

Changed to zip the artifacts directory instead. The workflow now creates cli-artifacts.zip from ./artifacts_download and attaches it to releases. Commit 33b6b5f.

Copilot AI changed the title Enable globstar for recursive artifact glob patterns in release workflow Zip CLI artifacts directory for release attachments Dec 6, 2025
@stesee stesee marked this pull request as ready for review December 6, 2025 14:35
Copilot AI review requested due to automatic review settings December 6, 2025 14:35
@stesee stesee merged commit 24e8006 into DiffMetadata Dec 6, 2025
5 of 7 checks passed
@stesee stesee deleted the copilot/sub-pr-75 branch December 6, 2025 14:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants