Skip to content

Conversation

Copy link

Copilot AI commented Nov 30, 2025

Addresses code review feedback from #75 regarding C# naming convention violations for method parameters.

Changes

  • Renamed Pic1, Pic2pic1, pic2 in CalcDiff and CalcDiffMaskImage overloads
  • Renamed PathPic1, PathPic2pathPic1, pathPic2 in CalcDiffMaskImage
  • Renamed PathActual, PathExpectedpathActual, pathExpected in ImagesAreEqual and ImagesHaveEqualSize
  • Updated corresponding XML doc <param> tags
// Before
public SKBitmap CalcDiffMaskImage(SKBitmap Pic1, SKBitmap Pic2)

// After
public SKBitmap CalcDiffMaskImage(SKBitmap pic1, SKBitmap pic2)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on 'Diff metadata' pull request Fix parameter naming from PascalCase to camelCase in ImageCompare.cs Nov 30, 2025
Copilot AI requested a review from stesee November 30, 2025 15:38
@stesee stesee closed this Dec 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
@stesee stesee deleted the copilot/sub-pr-75 branch December 6, 2025 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants