.Net 10 #35
Merged
.Net 10 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dotnet.yml
Create FUNDING.yml
Update README.md
Update FUNDING.yml
…ity; fix typos in test assertions and update package versions in project file
Update recommendations in extensions.json and enhance README for clar…
Update README.md
- Added postCreateCommand to install exfatprogs in devcontainer.json. - Updated CustomFsFileWriteAsserter to create and format a disk image as exFAT. - Refactored LinuxExFatSpecificTests to improve clarity and specificity in test naming.
… enhanced exFAT support
…d WindowsExFatSpecificTests for exFAT behavior validation
…es and improve error messages for exFAT file writing tests
…nditionally and improve disposal handling
…ledScope and ExFatFileWriteAsserterFactory. Update README with test setup instructions and refactor FileWriteAsserter for improved parameter handling.
…SanitizeFilename.csproj, add OS platform checks in AutoPlayDisabledScope, remove unnecessary whitespace in ExFatFileWriteAsserterFactory, and update NUnit and Microsoft.NET.Test.Sdk package versions.
…r exfatprogs, update README for clarity on enabling tests, and clean up code in FileWriteAsserter and ExFatFileWriteAsserterFactory.
ExFat tests
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…tions/checkout-5 Bump actions/checkout from 4 to 5
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4 to 5. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…tions/setup-dotnet-5 Bump actions/setup-dotnet from 4 to 5
…tions/stale-10 Bump actions/stale from 9 to 10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added .NET 10.0 to target frameworks and GitHub Actions workflows. Improved exFat test setup instructions and updated documentation for OS and filesystem compatibility. Added Unicode 16 emoji test and adjusted Unicode test cases for accuracy.
Updated SanitizeFilenameTests.csproj to include net10.0 in the TargetFrameworks for both Windows and non-Windows environments. This allows tests to run against the latest .NET version.
Removed net9.0 from test project target frameworks and limited non-Windows builds to net10.0. Also removed pull_request trigger from dotnet GitHub Actions workflow.
Update SanitizeFilenamesTests.cs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to support .NET 10.0, removes .NET 9.0 from non-Windows test targets, and adds comprehensive exFAT filesystem testing capabilities. Additionally, it includes dependency updates, typo corrections, and improvements to test infrastructure.
Key changes:
- Adds .NET 10.0 as a target framework across the solution
- Implements exFAT-specific testing with VHD mounting on Windows
- Updates NuGet package versions and GitHub Actions
- Corrects spelling errors ("framwework" → "framework")
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SanitizeFilenameTests/SanitizeFilenameTests.csproj | Updates target frameworks to include net10.0 and removes net9.0 from non-Windows targets; updates test SDK and analyzer versions |
| SanitizeFilename/SanitizeFilename.csproj | Adds net10.0 to target frameworks |
| SanitizeFilenameTests/FilenameTests/FileWriteAsserter.cs | Implements IDisposable pattern with support for exFAT VHD cleanup |
| SanitizeFilenameTests/FilenameTests/WindowsExFatSpecificTests.cs | New test class for Windows exFAT filesystem validation |
| SanitizeFilenameTests/ExFatTooling/ExFatFileWriteAsserterFactory.cs | New factory class for creating and managing exFAT test partitions via PowerShell |
| SanitizeFilenameTests/ExFatTooling/AutoPlayDisabledScope.cs | New utility class to temporarily disable Windows AutoPlay during exFAT VHD operations |
| Multiple test files | Replaces manual directory cleanup with Dispose() calls; fixes spelling errors; improves test assertions |
| README.md | Updates documentation to mention exFAT support and .NET platform compatibility |
| .github/workflows/dotnet.yml | Updates to actions/checkout@v5, actions/setup-dotnet@v5, and adds .NET 10.0 to workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+189
to
+191
| #pragma warning disable IDE0060 // unicodeVersionNote is used for documentation purposes only | ||
| public void ShouldNotBeTouchedBySanitizer(string unicodeSpecificEmoticon, int? unicodeVersion, string? expectedNetFramework, string unicodeVersionNote) | ||
| #pragma warning restore IDE0060 // unicodeVersionNote is used for documentation purposes only |
There was a problem hiding this comment.
The pragma warning directives for IDE0060 are duplicated. Line 238 restores the warning again, but it was already restored on line 191. Remove the duplicate restore on line 238.
| Assert.That(FileWriteAsserter.TryWriteFileToTempDirectory(unicodeSpecificEmoticon), Is.Not.EqualTo(RuntimeInformation.IsOSPlatform(OSPlatform.OSX))); | ||
| } | ||
| } | ||
| #pragma warning restore IDE0060 // unicodeVersionNote is used for documentation purposes only |
There was a problem hiding this comment.
This pragma warning restore is redundant. The warning was already restored on line 191 after the ShouldNotBeTouchedBySanitizer method.
Suggested change
| #pragma warning restore IDE0060 // unicodeVersionNote is used for documentation purposes only |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.