Net10 #34
Merged
Net10 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added .NET 10.0 to target frameworks and GitHub Actions workflows. Improved exFat test setup instructions and updated documentation for OS and filesystem compatibility. Added Unicode 16 emoji test and adjusted Unicode test cases for accuracy.
Updated SanitizeFilenameTests.csproj to include net10.0 in the TargetFrameworks for both Windows and non-Windows environments. This allows tests to run against the latest .NET version.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for .NET 10 to the SanitizeFilename project, updating target frameworks and correcting various inconsistencies in documentation.
- Adds .NET 10.0 to target frameworks across project files
- Updates documentation to improve consistency and accuracy
- Reorganizes Unicode test cases for better categorization
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SanitizeFilename/SanitizeFilename.csproj | Adds net10.0 to target frameworks |
| SanitizeFilenameTests/SanitizeFilenameTests.csproj | Adds net10.0 to target frameworks for tests |
| .github/workflows/dotnet.yml | Adds .NET 10.0.x to CI build matrix |
| SanitizeFilenameTests/FilenameTests/SanitizeFilenamesTests.cs | Moves Unicode 16 test case to appropriate test method |
| README.md | Updates documentation for consistency and accuracy |
| SanitizeFilename/docs/nugetReadme.md | Generalizes platform support description |
| SanitizeFilename.sln | Adds testenvironments.json to solution items |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Removed net9.0 from test project target frameworks and limited non-Windows builds to net10.0. Also removed pull_request trigger from dotnet GitHub Actions workflow.
Update SanitizeFilenamesTests.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.