Skip to content

Update SanitizeFilenamesTests.cs #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stesee merged 3 commits into from
Oct 16, 2025
Merged

Update SanitizeFilenamesTests.cs #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
385c39e
Update SanitizeFilenamesTests.cs
stesee Apr 23, 2025
5ab6261
Update SanitizeFilenameTests/FilenameTests/SanitizeFilenamesTests.cs
stesee Oct 16, 2025
01d18dc
Merge branch 'net10' into Unicode17Tests
stesee Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions SanitizeFilenameTests/FilenameTests/SanitizeFilenamesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public void ShouldNotBeTouchedBySanitizer(string unicodeSpecificEmoticon, int? u
// Unicode examples https://emojipedia.org/unicode-17.0
[TestCase("😀", "Unicode 6.1 example https://emojipedia.org/grinning-face")]
[TestCase("🚴", "Unicode 6 example https://emojipedia.org/person-biking")]
[TestCase("🙂", "Unicode 8 example https://emojipedia.org/person-biking")]
[TestCase("🙃", "Unicode 8 example https://emojipedia.org/upside-down-face")]
[TestCase("🤩", "Unicode 10 example https://emojipedia.org/star-struck#emoji")]
[TestCase("🥰", "Unicode 11 example https://emojipedia.org/smiling-face-with-hearts")]
[TestCase("🦿", "Unicode 12 example https://emojipedia.org/mechanical-leg")]
Expand All @@ -216,8 +216,7 @@ public void ShouldNotBeTouchedBySanitizer(string unicodeSpecificEmoticon, int? u
[TestCase("🫥", "Unicode 14 example https://emojipedia.org/dotted-line-face")]
[TestCase("🪿", "Unicode 15 example https://emojipedia.org/goose")]
[TestCase("🫩", "Unicode 16 example https://emojipedia.org/face-with-bags-under-eyes")]
#pragma warning disable IDE0060 // unicodeVersionNote is used for documentation purposes only
public void ShouldSanitizeUnicodeVersion9Plus(string unicodeSpecificEmoticon, string unicodeVersion)
public void SanitizesUnicodeCodePointsThatAreSupportedByEveryOs(string unicodeSpecificEmoticon, string unicodeVersion)
{
var sanitizedFilename = unicodeSpecificEmoticon.SanitizeFilename();
Assert.That(sanitizedFilename, Is.Not.EqualTo(unicodeSpecificEmoticon));
Expand All @@ -228,7 +227,7 @@ public void ShouldSanitizeUnicodeVersion9Plus(string unicodeSpecificEmoticon, st
// This emoticons are supported by every OS/FS tested, except macOS, because unicode 16 and 17 specific code points are not supported by macOS today
// Behavior on macos is expected to change over time
[TestCase("🫝", "Unicdoe 17 example https://emojipedia.org/apple-core")]
public void Unicode17SpecificMacoOsBehavior(string unicodeSpecificEmoticon, string unicodeVersion)
public void UnicodeSpecificMacoOsBehavior(string unicodeSpecificEmoticon, string unicodeVersion)
{
var sanitizedFilename = unicodeSpecificEmoticon.SanitizeFilename();
Assert.That(sanitizedFilename, Is.Not.EqualTo(unicodeSpecificEmoticon));
Expand Down