fix: catch invalid Google Charts format patterns and show i18n error#1272
Open
HardeepAsrani wants to merge 1 commit intodevelopmentfrom
Open
fix: catch invalid Google Charts format patterns and show i18n error#1272HardeepAsrani wants to merge 1 commit intodevelopmentfrom
HardeepAsrani wants to merge 1 commit intodevelopmentfrom
Conversation
Wrap gv.NumberFormat/DateFormat construction in a try/catch to prevent uncaught 'Too many percent/permill' errors from invalid ICU patterns. Show a localised error message inline below the format input field and clear it automatically when the pattern becomes valid.
pirate-bot
added
the
pr-checklist-incomplete
Contributor
Soare-Robert-Daniel
approved these changes
Mar 11, 2026
HardeepAsrani
added
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrap gv.NumberFormat/DateFormat construction in a try/catch to prevent uncaught 'Too many percent/permill' errors from invalid ICU patterns. Show a localised error message inline below the format input field and clear it automatically when the pattern becomes valid.
Will affect visual aspect of the product
YES/NO
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/visualizer-pro/issues/556.