fix: guard against undefined properties on license object in Library#1269
Open
HardeepAsrani wants to merge 2 commits intodevelopmentfrom
Open
fix: guard against undefined properties on license object in Library#1269HardeepAsrani wants to merge 2 commits intodevelopmentfrom
HardeepAsrani wants to merge 2 commits intodevelopmentfrom
Conversation
When the license option is stored as a stdClass without `key` or `download_id` properties (e.g. on a free/unlicensed install), PHP 8 throws an undefined-property notice. Add isset() guards so both properties fall back to an empty string.
HardeepAsrani
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
abaicus
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the license option is stored as a stdClass without
keyordownload_idproperties (e.g. on a free/unlicensed install), PHP 8 throws an undefined-property notice. Add isset() guards so both properties fall back to an empty string.Will affect visual aspect of the product
YES/NO
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/visualizer-pro/issues/559.