Skip to content

fix: manual config not working for ChartJS charts#1257

Merged
HardeepAsrani merged 1 commit intodevelopmentfrom
fix/issue-1184
Mar 10, 2026
Merged

fix: manual config not working for ChartJS charts#1257
HardeepAsrani merged 1 commit intodevelopmentfrom
fix/issue-1184

Conversation

@HardeepAsrani
Copy link
Member

Summary

Move override() to after settings.plugins.tooltip is assigned and before new Chart(), so manual config is applied last. Also change $.extend to deep merge so nested plugin options merge rather than replace, preserving tooltip callbacks.

Will affect visual aspect of the product

YES/NO

No

Screenshots

Test instructions

  • Make sure the Chart configs work.

Check before Pull Request is ready:

Closes #1184.

Move override() to after settings.plugins.tooltip is assigned and
before new Chart(), so manual config is applied last. Also change
$.extend to deep merge so nested plugin options merge rather than
replace, preserving tooltip callbacks.
@HardeepAsrani HardeepAsrani requested a review from abaicus March 2, 2026 22:25
@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Mar 2, 2026
@pirate-bot
Copy link
Contributor

Plugin build for 61103fa is ready 🛎️!

@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 2, 2026
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Mar 2, 2026
@HardeepAsrani HardeepAsrani merged commit 5da3eeb into development Mar 10, 2026
10 of 12 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/issue-1184 branch March 10, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants