Skip to content

18/19#3290

Draft
dreamwasp wants to merge 5 commits intocass-gm-plain-19from
cass-gm-plain-1819
Draft

18/19#3290
dreamwasp wants to merge 5 commits intocass-gm-plain-19from
cass-gm-plain-1819

Conversation

@dreamwasp
Copy link
Contributor

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to story X
  2. Do something
  3. Do that something in dark mode
  4. Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Mar 19, 2026

View your CI Pipeline Execution ↗ for commit 469095e


☁️ Nx Cloud last updated this comment at 2026-03-19 16:43:17 UTC

@codecov
Copy link

codecov bot commented Mar 19, 2026

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
818 3 815 0
View the top 3 failed test(s) by shortest run time
FeatureShimmer renders shimmer
Stack Traces | 0.004s run time
TypeError: rootInteresectionObserver.unobserve is not a function
    at InViewFeature.stopObserver (.../features/viewport/observers.ts:75:35)
    at InViewFeature.unmount (.../features/viewport/index.ts:91:26)
    at HTMLVisualElement.unmount (.../src/render/VisualElement.ts:520:25)
    at .../motion/utils/use-motion-ref.ts:56:74
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:874:13)
    at safelyDetachRef (.../react-dom/cjs/react-dom-client.development.js:13529:37)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14291:13)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14419:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14296:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14419:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14419:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseMutationEffects (.../react-dom/cjs/react-dom-client.development.js:14555:11)
    at commitMutationEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14883:11)
    at flushMutationEffects (.../react-dom/cjs/react-dom-client.development.js:17979:13)
    at commitRoot (.../react-dom/cjs/react-dom-client.development.js:17953:9)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:16667:15)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:18972:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:18814:21)
    at flushSyncWork$1 (.../react-dom/cjs/react-dom-client.development.js:16898:12)
    at ReactDOMRoot.Object.<anonymous>.process.env.NODE_ENV.ReactDOMHydrationRoot.unmount.ReactDOMRoot.unmount [as unmount] (.../react-dom/cjs/react-dom-client.development.js:27911:11)
    at Object.unmount (.../gamut/gamut/node_modules/@.../react/dist/pure.js:163:12)
    at .../gamut/gamut/node_modules/@.../react/dist/pure.js:307:12
    at .../gamut/gamut/node_modules/@.../react/dist/act-compat.js:47:24
    at Object.<anonymous>.process.env.NODE_ENV.exports.act (.../gamut/gamut/node_modules/react/cjs/react.development.js:814:22)
    at .../gamut/gamut/node_modules/@.../react/dist/act-compat.js:46:25
    at .../gamut/gamut/node_modules/@.../react/dist/pure.js:306:28
    at Array.forEach (<anonymous>)
    at cleanup (.../gamut/gamut/node_modules/@.../react/dist/pure.js:302:22)
    at Object.<anonymous> (.../gamut/gamut/node_modules/@.../react/dist/index.js:28:25)
    at Promise.then.completed (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:281:40)
    at async _runTest (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:254:5)
    at async _runTestsForDescribeBlock (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:126:9)
    at async _runTestsForDescribeBlock (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:121:9)
    at async run (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:71:3)
    at async runAndTransformResultsToJestFormat (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at async jestAdapter (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at async runTestInternal (.../gamut/gamut/node_modules/jest-runner/build/runTest.js:367:16)
    at async runTest (.../gamut/gamut/node_modules/jest-runner/build/runTest.js:444:34)
parseSelectOptions creates an option list
Stack Traces | 0.004s run time
Error: expect(received).toMatchSnapshot()

Snapshot name: `parseSelectOptions creates an option list 1`

- Snapshot  - 14
+ Received  + 26

  [
-   <option
-     data-testid="test-val"
-     label="Value"
-     value="val"
-   >
-     Value
-   </option>,
-   <option
-     data-testid="test-val2"
-     label="Value 2"
-     value="val2"
-   >
-     Value 2
-   </option>,
+   {
+     "$$typeof": Symbol(react.transitional.element),
+     "_owner": null,
+     "_store": {},
+     "key": "test-val",
+     "props": {
+       "children": "Value",
+       "data-testid": "test-val",
+       "label": "Value",
+       "value": "val",
+     },
+     "type": "option",
+   },
+   {
+     "$$typeof": Symbol(react.transitional.element),
+     "_owner": null,
+     "_store": {},
+     "key": "test-val2",
+     "props": {
+       "children": "Value 2",
+       "data-testid": "test-val2",
+       "label": "Value 2",
+       "value": "val2",
+     },
+     "type": "option",
+   },
  ]
    at Object.<anonymous> (.../Form/__tests__/utils.test.tsx:10:21)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at async _runTest (.../jest-circus/build/run.js:252:3)
    at async _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at async _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at async run (.../jest-circus/build/run.js:71:3)
    at async runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at async jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at async runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at async runTest (.../jest-runner/build/runTest.js:444:34)
FeatureShimmer renders shimmer when reduced motion is false
Stack Traces | 0.045s run time
TypeError: rootInteresectionObserver.unobserve is not a function
    at InViewFeature.stopObserver (.../features/viewport/observers.ts:75:35)
    at InViewFeature.unmount (.../features/viewport/index.ts:91:26)
    at HTMLVisualElement.unmount (.../src/render/VisualElement.ts:520:25)
    at .../motion/utils/use-motion-ref.ts:56:74
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:874:13)
    at safelyDetachRef (.../react-dom/cjs/react-dom-client.development.js:13529:37)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14291:13)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14419:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14296:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14419:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14419:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseDeletionEffects (.../react-dom/cjs/react-dom-client.development.js:14223:9)
    at commitDeletionEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14378:11)
    at recursivelyTraverseMutationEffects (.../react-dom/cjs/react-dom-client.development.js:14555:11)
    at commitMutationEffectsOnFiber (.../react-dom/cjs/react-dom-client.development.js:14883:11)
    at flushMutationEffects (.../react-dom/cjs/react-dom-client.development.js:17979:13)
    at commitRoot (.../react-dom/cjs/react-dom-client.development.js:17953:9)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:16667:15)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:18972:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:18814:21)
    at flushSyncWork$1 (.../react-dom/cjs/react-dom-client.development.js:16898:12)
    at ReactDOMRoot.Object.<anonymous>.process.env.NODE_ENV.ReactDOMHydrationRoot.unmount.ReactDOMRoot.unmount [as unmount] (.../react-dom/cjs/react-dom-client.development.js:27911:11)
    at Object.unmount (.../gamut/gamut/node_modules/@.../react/dist/pure.js:163:12)
    at .../gamut/gamut/node_modules/@.../react/dist/pure.js:307:12
    at .../gamut/gamut/node_modules/@.../react/dist/act-compat.js:47:24
    at Object.<anonymous>.process.env.NODE_ENV.exports.act (.../gamut/gamut/node_modules/react/cjs/react.development.js:814:22)
    at .../gamut/gamut/node_modules/@.../react/dist/act-compat.js:46:25
    at .../gamut/gamut/node_modules/@.../react/dist/pure.js:306:28
    at Array.forEach (<anonymous>)
    at cleanup (.../gamut/gamut/node_modules/@.../react/dist/pure.js:302:22)
    at Object.<anonymous> (.../gamut/gamut/node_modules/@.../react/dist/index.js:28:25)
    at Promise.then.completed (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:281:40)
    at async _runTest (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:254:5)
    at async _runTestsForDescribeBlock (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:126:9)
    at async _runTestsForDescribeBlock (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:121:9)
    at async run (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/run.js:71:3)
    at async runAndTransformResultsToJestFormat (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at async jestAdapter (.../gamut/gamut/node_modules/jest-config/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at async runTestInternal (.../gamut/gamut/node_modules/jest-runner/build/runTest.js:367:16)
    at async runTest (.../gamut/gamut/node_modules/jest-runner/build/runTest.js:444:34)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/gamut@68.1.3-alpha.53c3b0.0
@codecademy/gamut-icons@9.57.1-alpha.53c3b0.0
@codecademy/gamut-illustrations@0.58.8-alpha.53c3b0.0
@codecademy/gamut-kit@0.6.588-alpha.53c3b0.0
@codecademy/gamut-patterns@0.10.27-alpha.53c3b0.0
@codecademy/gamut-styles@17.12.2-alpha.53c3b0.0
@codecademy/gamut-tests@5.3.2-alpha.53c3b0.0
@codecademy/variance@0.26.1-alpha.53c3b0.0

@github-actions
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants