Skip to content

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Jan 30, 2026

Overview

  • Added logical properties for border related CSS properties
    • Border: borderX, borderY, borderTop, borderRight, borderBottom, borderLeft
    • Border Width: borderWidthX, borderWidthY, borderWidthTop, borderWidthRight, borderWidthBottom, borderWidthLeft
    • Border Color: borderColorX, borderColorY, borderColorTop, borderColorRight, borderColorBottom, borderColorLeft
    • Border Style: borderStyleX, borderStyleY, borderStyleTop, borderStyleRight, borderStyleBottom, borderStyleLeft
    • Border Radius: borderRadiusLeft, borderRadiusRight, borderRadiusTop, borderRadiusBottom, borderRadiusTopLeft, borderRadiusTopRight, borderRadiusBottomLeft, borderRadiusBottomRight
  • Updated Stories related to border related props

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1510
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to Foundations/System/Props/Border in Storybook
  2. Use the LogicalProps toggle in the toolbar to switch between "Logical" and "Physical" modes
  3. Inspect the rendered elements in each example to verify:
  • In Logical mode: Properties like border-inline-start, border-block-end-width, border-start-start-radius are used
  • In Physical mode: Properties like border-left, border-bottom-width, border-top-left-radius are used
  1. Repeat for Foundations/System/Props/Color to verify border color props
  2. Verify the TokenTable shows the correct properties based on the selected mode
  3. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@LinKCoding LinKCoding requested a review from a team as a code owner January 30, 2026 15:33
@LinKCoding LinKCoding requested review from dreamwasp and sh0ji and removed request for a team January 30, 2026 15:33
@LinKCoding LinKCoding marked this pull request as draft January 30, 2026 15:33
@nx-cloud
Copy link

nx-cloud bot commented Jan 30, 2026

View your CI Pipeline Execution ↗ for commit e3a90e3


☁️ Nx Cloud last updated this comment at 2026-01-30 18:51:28 UTC

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.41%. Comparing base (1f6e194) to head (e3a90e3).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           kl-gmt-1508v2-margin-padding    #3257      +/-   ##
================================================================
+ Coverage                         89.09%   89.41%   +0.32%     
================================================================
  Files                               236      341     +105     
  Lines                              4309     4763     +454     
  Branches                           1478     1551      +73     
================================================================
+ Hits                               3839     4259     +420     
- Misses                              462      496      +34     
  Partials                              8        8              
Flag Coverage Δ
pull-request 89.41% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/gamut@68.0.1-alpha.5b7e3d.0
@codecademy/gamut-icons@9.54.3-alpha.5b7e3d.0
@codecademy/gamut-illustrations@0.58.3-alpha.5b7e3d.0
@codecademy/gamut-kit@0.6.580-alpha.5b7e3d.0
@codecademy/gamut-patterns@0.10.22-alpha.5b7e3d.0
@codecademy/gamut-styles@17.11.3-alpha.5b7e3d.0
@codecademy/gamut-tests@5.2.20-alpha.5b7e3d.0
@codecademy/styleguide@79.0.1-alpha.5b7e3d.0
@codecademy/variance@0.25.3-alpha.5b7e3d.0

@github-actions
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants