-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Updates to ThemeProvider, tokens, and transform to allow Logical vs Physical prop resolution #3234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: kl-gmt-1451-logical-props
Are you sure you want to change the base?
feat: Updates to ThemeProvider, tokens, and transform to allow Logical vs Physical prop resolution #3234
Conversation
|
View your CI Pipeline Execution ↗ for commit 1f6e194 ☁️ Nx Cloud last updated this comment at |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many --target=build --all |
❌ Failed | 3s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-13 20:18:04 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## kl-gmt-1451-logical-props #3234 +/- ##
============================================================
Coverage ? 89.09%
============================================================
Files ? 236
Lines ? 4309
Branches ? 1478
============================================================
Hits ? 3839
Misses ? 462
Partials ? 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📬 Published Alpha Packages: |
|
🚀 Styleguide deploy preview ready! Preview URL: https://697bb6d245f55d051f06f912--gamut-preview.netlify.app |
| expect(rowEl).toHaveStyle({ columnGap: theme.spacing[40] }); | ||
| }); | ||
|
|
||
| // Note: Only testing one mode here since variant() caches styles after first render. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out that variant() was caching the CSS object created and thus not switching between logical and physical properties even after setting useLogicalProperties as false.
This was found downstream in createCss and also also for the MockGamutProvider

Overview
useLogicalPropertieswhich defaults totrue, to GamutProvidertransformto resolve the correct CSS property to useuseLogicalPropertiesPR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs